fix: Estimation should be sent to webhook URL even if output is disabled

Fixes #274
TheCloudTheory · Sep 3, 2024 · e725e7e · e725e7e
1 parent c98d8bd
commit e725e7e
Showing 1 changed file with 25 additions and 25 deletions.
diff --git a/ace/Output/OutputHandler.cs b/ace/Output/OutputHandler.cs
@@ -56,35 +56,35 @@ public async Task GenerateOutputIfNeeded(EstimateOptions options, EstimationOutp
                     var generator = new MarkdownOutputGenerator(output, logger, options.MarkdownOutputFilename);
                     generator.Generate();
                 }
+            }
 
-                if (!string.IsNullOrEmpty(options.WebhookUrl))
-                {
-                    logger.AddEstimatorMessage("Sending estimation result to webhook URL {0}", options.WebhookUrl);
+            if (!string.IsNullOrEmpty(options.WebhookUrl))
+            {
+                logger.AddEstimatorMessage("Sending estimation result to webhook URL {0}", options.WebhookUrl);
 
-                    var client = new HttpClient();
-                    var message = new HttpRequestMessage(HttpMethod.Post, options.WebhookUrl)
-                    {
-                        Content = new StringContent(JsonSerializer.Serialize(output), Encoding.UTF8, "application/json")
-                    };
+                using var client = new HttpClient();
+                var message = new HttpRequestMessage(HttpMethod.Post, options.WebhookUrl)
+                {
+                    Content = new StringContent(JsonSerializer.Serialize(output), Encoding.UTF8, "application/json")
+                };
 
-                    if (string.IsNullOrEmpty(options.WebhookAuthorization))
-                    {
-                        logger.AddEstimatorMessage("Webhook authorization header not set, skipping.");
-                    }
-                    else
-                    {
-                        message.Headers.Add("Authorization", options.WebhookAuthorization);
-                    }
+                if (string.IsNullOrEmpty(options.WebhookAuthorization))
+                {
+                    logger.AddEstimatorMessage("Webhook authorization header not set, skipping.");
+                }
+                else
+                {
+                    message.Headers.Add("Authorization", options.WebhookAuthorization);
+                }
 
-                    var response = await client.SendAsync(message);
-                    if (!response.IsSuccessStatusCode)
-                    {
-                        logger.LogError("Couldn't send estimation result to webhook URL {url}. Status code: {code}", options.WebhookUrl, response.StatusCode);
-                    }
-                    else
-                    {
-                        logger.AddEstimatorMessage("Estimation result sent successfully to webhook URL {0}", options.WebhookUrl);
-                    }
+                var response = await client.SendAsync(message);
+                if (!response.IsSuccessStatusCode)
+                {
+                    logger.LogError("Couldn't send estimation result to webhook URL {url}. Status code: {code}", options.WebhookUrl, response.StatusCode);
+                }
+                else
+                {
+                    logger.AddEstimatorMessage("Estimation result sent successfully to webhook URL {0}", options.WebhookUrl);
                 }
             }