Skip to content

Removed deprecated CMake functions and removed unused link #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nepp95
Copy link

@nepp95 nepp95 commented Mar 2, 2025

This PR removes deprecated CMake functions as well as removing the call to link the glm library which is never compiled, only included as a header. There also was a compilation error because of not including the vector std lib.

As part of updating the CMake function, the find_package calls are also redundant since they can be done as part of the FetchContent_Declare call. When adding FIND_PACKAGE_ARGS to the call, it will attempt to find it first using find_package.

This ensures this repository stays relevant and compilable out of the box instead of having to fix the CMakeLists file in the future. On most modern CMake versions, the current version already spits out warnings while configuring.

@nepp95
Copy link
Author

nepp95 commented Mar 2, 2025

I should add:

If you want to reference a specific commit, that can also be put in place of the tag with the same syntax (also using GIT_TAG). This is the recommended way per CMake documentation, although a tag in most cases should suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant