Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format option "ALAC" #28

Closed
Chris230291 opened this issue Mar 17, 2022 · 6 comments
Closed

Format option "ALAC" #28

Chris230291 opened this issue Mar 17, 2022 · 6 comments
Assignees
@TheCaptain989
Labels
enhancement New feature or request

Comments

@Chris230291
Copy link

Hi. Could you add support for flac2alac please?

ffmpeg -i input.flac -c:v copy -c:a alac output.m4a

Is it possible to batch convert like in your Sonarr/Radarr script?
@TheCaptain989
Copy link
Owner

TheCaptain989 commented Mar 18, 2022 •
edited
Loading

You can code in ALAC support (or any other ffmpeg supported format) by creating a custom wrapper script. I discuss this in the Syntax part of the README.

In your case, based on your question above I would create a /config/flac2alac.sh file that looks like the following:

#!/bin/bash

. /usr/local/bin/flac2mp3.sh -a "-c:v copy -c:a alac" -e m4a

Let me know how that works out. You may find you also have to include a bitrate, via -b:a.

To your second point, I have considered a batch mode, but there are file tagging issues that with that approach that aren't easily addressed. However, let me take a fresh look at this.

@Chris230291
Copy link
Author

Thanks

TheCaptain989 added a commit that referenced this issue Apr 10, 2022
@TheCaptain989
Release 2 candidate 1
b970076 
- Added batch mode per issue #28
- Moved option check earlier in the script and completely reworked options/arguments processing
- Added long arguments options
- Added debug info for system API
- Added debug info for config API
- Added multiple debug logging levels, defaults to lowest
  Default debug level excludes the returned JSON, making it more readable and useful
- Updated help text
- Updated README
- Normalized test event output
- Added ALAC wrapper script
@TheCaptain989
Copy link
Owner

Thanks

@Chris230291, I added the batch mode to this dev repo. Please test it out.

@TheCaptain989 TheCaptain989 self-assigned this Apr 10, 2022
@TheCaptain989 TheCaptain989 added the enhancement New feature or request label Apr 10, 2022
@Chris230291
Copy link
Author

Thanks. Unfortunately I have already converted existing tracks using db power amp. By the way he correct command for alac is . /usr/local/bin/flac2mp3.sh -a "-vn -acodec alac" -e m4a this stops a lot of errors with album art metadata etc. Its not such a big deal omitting it because Lidarr can just add it back.

@TheCaptain989
Copy link
Owner

Thanks!

@TheCaptain989
Copy link
Owner

Release 2.0 closed this.

@TheCaptain989 TheCaptain989 mentioned this issue May 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCaptain989 TheCaptain989

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chris230291 @TheCaptain989