Add Bcrypt hashing #27

Jujumba · 2023-05-19T19:13:23Z

Add Bcrypt hashing with some raw functionality (salt parsing and hash verification). Requires review.

TheBestTvarynka

you are doing well

src/crypto_helper/input/bcrypt.rs

TheBestTvarynka · 2023-05-20T10:41:32Z

#4

…tification when user enters invalid input

todo: add byte input for salt bcrypt: add salt parsing (bugged!)

Jujumba · 2023-05-20T19:18:05Z

Sorry for other commits, I'm accidentally 😅

# Conflicts: # src/crypto_helper/algorithm.rs # src/crypto_helper/computations.rs # src/crypto_helper/input/bcrypt.rs

TheBestTvarynka

I've enabled CI for your PR. Run cargo +nightly fmt --all -- --check and cargo clippy -- -D warnings to see where and why it fails. Fix warnings and errors.
Fix my remarks.
And then I'll approve your PR.

🌷 ☕ 🤩

src/crypto_helper.rs

src/crypto_helper/algorithm.rs

src/crypto_helper/input/bcrypt.rs

code-style hints

TheBestTvarynka

good job. 🥑

src/crypto_helper/input/bcrypt.rs

src/crypto_helper/output.rs

src/crypto_helper/input/bcrypt.rs

src/crypto_helper/algorithm.rs

TheBestTvarynka

🥳 🍾

Add Bcrypt hashing

2352887

TheBestTvarynka self-requested a review May 20, 2023 10:25

TheBestTvarynka assigned Jujumba May 20, 2023

TheBestTvarynka added the crypto-helper Changes in the crypto-helper page label May 20, 2023

TheBestTvarynka requested changes May 20, 2023

View reviewed changes

src/crypto_helper/input/bcrypt.rs Outdated Show resolved Hide resolved

src/crypto_helper/input/bcrypt.rs Outdated Show resolved Hide resolved

src/crypto_helper/input/bcrypt.rs Outdated Show resolved Hide resolved

TheBestTvarynka and others added 4 commits May 20, 2023 20:27

feat(common): ByteInput: paint component in red instead of showing no…

bdbb219

…tification when user enters invalid input

small refactoring

1f3f057

fix(common): ByteInput: formatting on input data change

acd108b

Add Bcrypt hashing

67b3044

todo: add byte input for salt bcrypt: add salt parsing (bugged!)

Jujumba force-pushed the Bcrypt branch from 2352887 to 67b3044 Compare May 20, 2023 18:56

Jujumba and others added 10 commits May 20, 2023 22:47

Bcrypt: Add salt parsing

52c674c

fix(crypto-helper): bcrypt: salt input

d6bb548

Bcrypt: implement convertion BcryptAction -> bool

955f536

Bcrypt: Add switch and verify callback (bugged)

40bf207

Merge branch 'temp' into Bcrypt

f9e014e

# Conflicts: # src/crypto_helper/algorithm.rs # src/crypto_helper/computations.rs # src/crypto_helper/input/bcrypt.rs

fix(crypto-helper): bcrypt: salt input

906b512

fix(crypto-helper): bcrypt: switcher works now;

dc2c55e

computations.rs: refactor: check salt len once in hash_bcrypt()

fdae766

bcrypt: refactor: refactor boss code😎 and remove unused code

cc74730

bcrypt: impl default for BcryptHashAction

a749395

TheBestTvarynka self-requested a review May 21, 2023 19:30

TheBestTvarynka marked this pull request as ready for review May 21, 2023 19:33

TheBestTvarynka requested changes May 21, 2023

View reviewed changes

Jujumba added 5 commits May 21, 2023 22:24

Apply cargo fmt code-style checks

e88bf66

algorithm.rs: add custom (de)serializers

df3c973

bcrypt: rename BI -> BcryptInputData

a514616

computations: merge bcrypt processing function into one and apply

a07fd3f

code-style hints

bcrypt: notify about errors with invalid states and notifications

ffd79ba

Jujumba added 3 commits May 22, 2023 00:01

bcrypt: format html and use ascii byte format by default

fd5d3d5

bcrypt: refactor: simplify conversion action -> bool

ab3099f

computations: remove borrowing

ca0b384

TheBestTvarynka self-requested a review May 22, 2023 10:14

TheBestTvarynka requested changes May 22, 2023

View reviewed changes

Jujumba added 3 commits May 22, 2023 13:25

bcrypt: remove redundant logic

d1f5d77

bcrypt: avoid unnecessary data move

4852742

bcrypt: input: change class

68a7244

Jujumba requested a review from TheBestTvarynka May 22, 2023 11:28

TheBestTvarynka approved these changes May 22, 2023

View reviewed changes

TheBestTvarynka merged commit 5ff4d5c into TheBestTvarynka:main May 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Bcrypt hashing #27

Add Bcrypt hashing #27

Jujumba commented May 19, 2023

TheBestTvarynka left a comment

TheBestTvarynka commented May 20, 2023

Jujumba commented May 20, 2023

TheBestTvarynka left a comment •

edited

Loading

TheBestTvarynka left a comment

TheBestTvarynka left a comment

Add Bcrypt hashing #27

Add Bcrypt hashing #27

Conversation

Jujumba commented May 19, 2023

TheBestTvarynka left a comment

Choose a reason for hiding this comment

TheBestTvarynka commented May 20, 2023

Jujumba commented May 20, 2023

TheBestTvarynka left a comment • edited Loading

Choose a reason for hiding this comment

TheBestTvarynka left a comment

Choose a reason for hiding this comment

TheBestTvarynka left a comment

Choose a reason for hiding this comment

TheBestTvarynka left a comment •

edited

Loading