Skip to content
This repository was archived by the owner on Mar 1, 2021. It is now read-only.

Conversation

@theNaut1lus
Copy link
Contributor

This PR is a big one.
While I had set out to implement #27 I got a little carried away and implemented some more changes like the ones you will see in my branch.

  1. added svg logos for all languages (could only find png for Matlab but resized to make it similar to an svg)
  2. changed the list to a table to make a grid of options instead of a list causing the user to scroll
  3. made some grammatical changes.
  4. added robot font for the body texts
  5. removed call to source sans pro as it was a redundant call and would have slowed down loading.
  6. corresponding UI changes in CSS.

P.S: have for now not created class names for small elements assuming that they won't appear again in this splash page.

Before
Screenshot 2019-05-08 at 9 49 36 PM

After
Screenshot 2019-05-08 at 9 49 21 PM

P.P.S: Have plenty of ideas for new changes and all, will wait for this PR's resolution before working further.

/cc: @AnshulMalik

Sidak Singh Aulakh added 2 commits May 8, 2019 21:40
added icons and other minor changes to convert the list into a table to make it more better.
Some minor changes to css to achieve
Removed Source Sans font call as it was never used.
Added bold type set for icons
added small grammatical changes and also added robot font for the body text for better readability.
@theNaut1lus theNaut1lus changed the title Added svg icons of languages, fixed some css, grammar and added robot fonts. Added svg icons of languages, fixed some css, grammar and added roboto fonts. May 8, 2019
@AnshulMalik
Copy link
Member

Nice work! Few things to mention though.

This is a perfect example to use css grids instead of tables :) And we'd ideally like to display vertically centered to the icon(it goes to the bottom of the icon currently).
And we'll probably won't need the border of the table.

Well done :)

@theNaut1lus
Copy link
Contributor Author

theNaut1lus commented May 9, 2019

@AnshulMalik
We could use grids but that could cause unnecessary complications to the css, or if you agree on using a pre-defined grid library we could call it via a cdn which will only load the modules called in the code. What do you say. 😃
P.S: I know that the primary library that comes to mind is bootstrap but there are far more better and lighter grid-only css libraries out there for us to choose from. 🔥

@AnshulMalik
Copy link
Member

Please have a look at this article https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout/Basic_Concepts_of_Grid_Layout

We don't need those libraries at all :)

1. There is now the use of css grids instead of simple tables to list all the algorithm repos.
2. the border is removed.
3. the names are below the icons now.
@theNaut1lus
Copy link
Contributor Author

@AnshulMalik
have made the required changes, please check.

Updated Screenshot:
Screenshot 2019-05-16 at 11 31 14 PM

@AnshulMalik
Copy link
Member

This looks awesome :)
Just one thought, the language icon and text look like they are separated by a large space and the text is closer to the other language's icon. Can we make it such that the language name is closer to it's icon? this would then be perfect :)

@theNaut1lus
Copy link
Contributor Author

theNaut1lus commented May 17, 2019

@AnshulMalik made the requested changes. 👍
looks much cleaner now.

Screenshot 2019-05-17 at 2 07 36 PM

@AnshulMalik
Copy link
Member

This is perfect :) And ready to merge :)
It would be cherry on cake, if we can make do something on hover on any language or it's icon.
May be slight darker background and make this whole box clickable.

But that can be done in another PR, Love this :)

@AnshulMalik AnshulMalik merged commit a60036b into TheAlgorithms:master May 17, 2019
@theNaut1lus
Copy link
Contributor Author

It would be cherry on cake, if we can make do something on hover on any language or it's icon.

@AnshulMalik would love to work on this as well, look out for another issue and PR soon 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants