-
-
Notifications
You must be signed in to change notification settings - Fork 131
Added svg icons of languages, fixed some css, grammar and added roboto fonts. #28
Conversation
added icons and other minor changes to convert the list into a table to make it more better. Some minor changes to css to achieve Removed Source Sans font call as it was never used. Added bold type set for icons
added small grammatical changes and also added robot font for the body text for better readability.
|
Nice work! Few things to mention though. This is a perfect example to use css grids instead of tables :) And we'd ideally like to display vertically centered to the icon(it goes to the bottom of the icon currently). Well done :) |
|
@AnshulMalik |
|
Please have a look at this article https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout/Basic_Concepts_of_Grid_Layout We don't need those libraries at all :) |
1. There is now the use of css grids instead of simple tables to list all the algorithm repos. 2. the border is removed. 3. the names are below the icons now.
|
@AnshulMalik |
|
This looks awesome :) |
|
@AnshulMalik made the requested changes. 👍 |
|
This is perfect :) And ready to merge :) But that can be done in another PR, Love this :) |
@AnshulMalik would love to work on this as well, look out for another issue and PR soon 😄 |


This PR is a big one.
While I had set out to implement #27 I got a little carried away and implemented some more changes like the ones you will see in my branch.
P.S: have for now not created class names for small elements assuming that they won't appear again in this splash page.
Before

After

P.P.S: Have plenty of ideas for new changes and all, will wait for this PR's resolution before working further.
/cc: @AnshulMalik