Fix bounds on delete_ith#880
Merged
vil02 merged 1 commit intoTheAlgorithms:masterfrom May 19, 2025
actuallyatiger:master
Merged
Fix bounds on delete_ith#880vil02 merged 1 commit intoTheAlgorithms:masterfrom actuallyatiger:master
vil02 merged 1 commit intoTheAlgorithms:masterfrom
actuallyatiger:master
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #880 +/- ##
==========================================
+ Coverage 95.50% 95.51% +0.01%
==========================================
Files 317 317
Lines 22948 22955 +7
==========================================
+ Hits 21916 21925 +9
+ Misses 1032 1030 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vil02
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fixes #879
Updates the out-of-bounds check to include
length = indexand also adjusts the bound on the call todelete_tailso that it can actually be used.Also added a test case for when
length = indexType of change
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.COUNTRIBUTING.mdand my code follows its guidelines.