Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fisher yates shuffle #394

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Added fisher yates shuffle #394

merged 3 commits into from
Oct 13, 2022

Conversation

jerr-it
Copy link
Contributor

@jerr-it jerr-it commented Oct 1, 2022

No description provided.

@jerr-it jerr-it requested review from siriak and imp2002 as code owners October 1, 2022 19:47
@merelymyself
Copy link
Contributor

As a rule, we try to reduce the number of crates we have as dependencies. Is there an implementation without rand?

@jerr-it
Copy link
Contributor Author

jerr-it commented Oct 2, 2022

I don't think it's possible to implement the Fisher-Yates-Shuffle without randomness. But using the random generator in math/random.rs should work.

siriak
siriak approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 13, 2022 07:24
@siriak siriak merged commit 75fcde9 into TheAlgorithms:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@imp2002 imp2002 Awaiting requested review from imp2002 imp2002 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerr-it @merelymyself @siriak