Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the algorithm to compute Reynolds number in the physics section #9913

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Added the algorithm to compute Reynolds number in the physics section #9913

merged 3 commits into from
Oct 10, 2023

Conversation

pluto-tofu
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 6, 2023
tianyizheng02
tianyizheng02 approved these changes Oct 10, 2023
View reviewed changes
physics/reynolds_number.py Outdated Show resolved Hide resolved
physics/reynolds_number.py Outdated Show resolved Hide resolved
physics/reynolds_number.py Outdated Show resolved Hide resolved
@tianyizheng02 tianyizheng02 merged commit f3acb52 into TheAlgorithms:master Oct 10, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 10, 2023
@tianyizheng02
Copy link
Contributor

Thanks for your contribution!

@pluto-tofu pluto-tofu deleted the reynolds_number branch October 10, 2023 15:56
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@pluto-tofu @tianyizheng02 @sedatguzelsemme
Added the algorithm to compute Reynolds number in the physics section (…
5090e86 
…TheAlgorithms#9913)

* added the algorithm to compute Reynolds number

* fixed file name issue

* Apply suggestions from code review

---------

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pluto-tofu @tianyizheng02