Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add median of matrix #9363

Merged
merged 7 commits into from
Oct 4, 2023
Merged

add median of matrix #9363

merged 7 commits into from
Oct 4, 2023

Conversation

BamaCharanChhandogi
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 2, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 2, 2023
@BamaCharanChhandogi
Copy link
Member Author

BamaCharanChhandogi commented Oct 2, 2023 •
edited
Loading

This is the first PR of the median of the matrix.
@cclauss can you please check?

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 2, 2023
@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 2, 2023
Closed
14 tasks
@BamaCharanChhandogi
Copy link
Member Author

@cclauss check, please!

cclauss
cclauss reviewed Oct 4, 2023
View reviewed changes
matrix/median_matrix.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Oct 4, 2023
View reviewed changes
matrix/median_matrix.py Outdated Show resolved Hide resolved
@cclauss cclauss enabled auto-merge (squash) October 4, 2023 17:21
cclauss
cclauss approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this!!!

@cclauss cclauss merged commit 922d6a8 into TheAlgorithms:master Oct 4, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 4, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@BamaCharanChhandogi @pre-commit-ci
@cclauss @sedatguzelsemme
add median of matrix (TheAlgorithms#9363)
9c52ae0 
* add median of matrix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix formating

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BamaCharanChhandogi @cclauss