Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename norgate to nor_gate to keep consistency #8968

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Rename norgate to nor_gate to keep consistency #8968

merged 2 commits into from
Aug 17, 2023

Conversation

CaedenPH
Copy link
Contributor

Describe your change:

Renames norgate to nor_gate to keep consistency with the other file names and with pep-8

image

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

This was referenced Aug 16, 2023
Closed
Closed
@CaedenPH
Copy link
Contributor Author

@tianyizheng02 Easy merge if you agree with this change

@tianyizheng02 tianyizheng02 merged commit fd7cc4c into TheAlgorithms:master Aug 17, 2023
@CaedenPH CaedenPH deleted the rename-norgate branch August 17, 2023 07:47
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@CaedenPH @sedatguzelsemme
Rename norgate to nor_gate to keep consistency (TheAlgorithms#8968)
abf843a 
* refactor(boolean-algebra): Rename norgate to nor_gate

* updating DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaedenPH @tianyizheng02