Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Graph Implementations #8730

Merged
merged 12 commits into from
May 31, 2023
Merged

Improved Graph Implementations #8730

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f520fb9
Improved Graph Implementations
nith2001 May 14, 2023
2b6b70f
Graph implementation style fixes, corrections, and refactored tests
nith2001 May 15, 2023
f741760
Helpful docs about graph implementation
nith2001 May 15, 2023
ef4f4c8
Refactored code to separate files and applied enumerate()
nith2001 May 25, 2023
b64adc1
Renamed files and refactored code to fail fast
nith2001 May 25, 2023
64adc48
Error handling style fix
nith2001 May 30, 2023
438d19a
Fixed f-string code quality issue
nith2001 May 30, 2023
b7f8582
Last f-string fix
nith2001 May 30, 2023
5081bcd
Added return types to test functions and more style fixes
nith2001 May 30, 2023
115b0e2
Added more function return types
nith2001 May 30, 2023
0ebfc8c
Added more function return types pt2
nith2001 May 30, 2023
f1426c8
Fixed error messages
nith2001 May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed error messages
  • Loading branch information
@nith2001
nith2001 committed May 31, 2023
commit f1426c8bdf764d7f3f4404a60b6343705f8c4849
4 changes: 2 additions & 2 deletions graphs/graph_adjacency_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def add_edge(self, source_vertex: T, destination_vertex: T) -> None:
if self.contains_edge(source_vertex, destination_vertex):
msg = (
"Incorrect input: The edge already exists between "
f"{source_vertex} or {destination_vertex}"
f"{source_vertex} and {destination_vertex}"
)
raise ValueError(msg)

Expand Down Expand Up @@ -134,7 +134,7 @@ def remove_edge(self, source_vertex: T, destination_vertex: T) -> None:
if not self.contains_edge(source_vertex, destination_vertex):
msg = (
"Incorrect input: The edge does NOT exist between "
f"{source_vertex} or {destination_vertex}"
f"{source_vertex} and {destination_vertex}"
)
raise ValueError(msg)

Expand Down
4 changes: 2 additions & 2 deletions graphs/graph_adjacency_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def add_edge(self, source_vertex: T, destination_vertex: T) -> None:
if self.contains_edge(source_vertex, destination_vertex):
msg = (
"Incorrect input: The edge already exists between "
f"{source_vertex} or {destination_vertex}"
f"{source_vertex} and {destination_vertex}"
)
raise ValueError(msg)

Expand Down Expand Up @@ -101,7 +101,7 @@ def remove_edge(self, source_vertex: T, destination_vertex: T) -> None:
if not self.contains_edge(source_vertex, destination_vertex):
msg = (
"Incorrect input: The edge does NOT exist between "
f"{source_vertex} or {destination_vertex}"
f"{source_vertex} and {destination_vertex}"
)
raise ValueError(msg)

Expand Down