Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New gitter link added or replaced #8551

Merged
merged 9 commits into from
Mar 26, 2023
Merged

New gitter link added or replaced #8551

merged 9 commits into from
Mar 26, 2023

Conversation

KaixLina
Copy link
Contributor

@KaixLina KaixLina commented Mar 26, 2023 •
edited by cclauss
Loading

Describe your change:

Fixes #8546

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Mar 26, 2023
@algorithms-keeper
Copy link

Closing this pull request as invalid

@KaixLina, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Mar 26, 2023
@cclauss cclauss reopened this Mar 26, 2023
@algorithms-keeper algorithms-keeper bot added documentation This PR modified documentation files tests are failing Do not merge until tests pass labels Mar 26, 2023
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Mar 26, 2023
@cclauss cclauss changed the title New gitter link added or replaced ; New gitter link added or replaced Mar 26, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Mar 26, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Mar 26, 2023
@cclauss cclauss merged commit 7cdb011 into TheAlgorithms:master Mar 26, 2023
@ChVeen
Copy link
Contributor

ChVeen commented Mar 26, 2023

Hi @KaixLina, you may have a look to PR #8546, I solved the issue already on my own, since after days no one did it... sorry.

@cclauss
Copy link
Member

cclauss commented Mar 26, 2023

Sorry. A ruff upgrade got in the way of both of these pull requests. I picked this one instead of #8546 because it updated the Gitter URL in a few more places. Thanks for your contributions.

tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@KaixLina @cclauss @tianyizheng02
New gitter link added or replaced (TheAlgorithms#8551)
78dafd8 
* New gitter link added

* ruff==0.0.258

* noqa: S310

* noqa: S310

* Update ruff.yml

* Add Ruff rule S311

* Ruff v0.0.259

* return ("{:08x}" * 5).format(*self.h)

* pickle.load(f)  # noqa: S301

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@KaixLina @cclauss @sedatguzelsemme
New gitter link added or replaced (TheAlgorithms#8551)
996a606 
* New gitter link added

* ruff==0.0.258

* noqa: S310

* noqa: S310

* Update ruff.yml

* Add Ruff rule S311

* Ruff v0.0.259

* return ("{:08x}" * 5).format(*self.h)

* pickle.load(f)  # noqa: S301

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
documentation This PR modified documentation files invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaixLina @ChVeen @cclauss