Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New contribution: fix_ci_badge #8134

Merged
merged 1 commit into from
Feb 12, 2023
Merged

New contribution: fix_ci_badge #8134

merged 1 commit into from
Feb 12, 2023

Conversation

SheriffHobo
Copy link
Contributor

Describe your change:

Updated the image for Line 25.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • [ X] Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed documentation This PR modified documentation files labels Feb 11, 2023
@Panquesito7
Copy link
Member

Should we accept this or accept #8136?
I think we should accept this as it was made first.

CC: @cclauss, @dhruvmanila.

@mehrdadbn9 mehrdadbn9 mentioned this pull request Feb 12, 2023
Closed
@cclauss cclauss merged commit 77b4fa8 into TheAlgorithms:master Feb 12, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Feb 12, 2023
Panquesito7
Panquesito7 reviewed Feb 12, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🎉

Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@SheriffHobo @Cjkjvfnby
fix_ci_badge (TheAlgorithms#8134)
47c0eb5
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Mar 19, 2023
@SheriffHobo @sedatguzelsemme
fix_ci_badge (TheAlgorithms#8134)
f0b10f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
documentation This PR modified documentation files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SheriffHobo @Panquesito7 @cclauss