Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit tests for sorting functions, and improving readability on some sorting algorithms #784

Merged
merged 12 commits into from
May 25, 2019
Merged

Adding unit tests for sorting functions, and improving readability on some sorting algorithms #784

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0a0fe91
Adding variable to fade out ambiguity
alaouimehdi1995 May 4, 2019
4aa9ea9
More readability on merge sorting algorithm
alaouimehdi1995 May 4, 2019
affd6a0
Updating merge_sort_fastest description and explaining why
alaouimehdi1995 May 4, 2019
e04800b
Adding tests file with imports
alaouimehdi1995 May 4, 2019
23a0527
Standardazing filenames and function names
alaouimehdi1995 May 5, 2019
abba6a0
Adding test cases and test functions
alaouimehdi1995 May 5, 2019
31362cb
Adding test loop
alaouimehdi1995 May 5, 2019
76ed0f8
Putting 'user oriented code' inside main condition for having valid i…
alaouimehdi1995 May 5, 2019
4d323f9
Fixing condition
alaouimehdi1995 May 5, 2019
ed5bfaa
Updating tests: adding cases and todo list
alaouimehdi1995 May 5, 2019
a512080
Refactoring first euler problem's first solution
alaouimehdi1995 May 5, 2019
2a343b2
Merge branch 'master' into master
poyea May 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Adding variable to fade out ambiguity
  • Loading branch information
@alaouimehdi1995
alaouimehdi1995 committed May 4, 2019
commit 0a0fe917ddbeaaf2fc93a869b1986544b8e41d28
10 changes: 6 additions & 4 deletions sorts/insertion_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@ def insertion_sort(collection):
>>> insertion_sort([-2, -5, -45])
[-45, -5, -2]
"""
for index in range(1, len(collection)):
while index > 0 and collection[index - 1] > collection[index]:
collection[index], collection[index - 1] = collection[index - 1], collection[index]
index -= 1

for loop_index in range(1, len(collection)):
insertion_index = loop_index
while insertion_index > 0 and collection[insertion_index - 1] > collection[insertion_index]:
collection[insertion_index], collection[insertion_index - 1] = collection[insertion_index - 1], collection[insertion_index]
insertion_index -= 1

return collection

Expand Down