Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyupgrade --py310-plus and run mypy in precommit, not build #5996

Merged
merged 5 commits into from
Feb 13, 2022
Merged

pyupgrade --py310-plus and run mypy in precommit, not build #5996

merged 5 commits into from
Feb 13, 2022

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Feb 13, 2022

Describe your change:

  • Improve tests
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested review from poyea and dhruvmanila February 13, 2022 09:25
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Feb 13, 2022
@ghost ghost added the tests are failing Do not merge until tests pass label Feb 13, 2022
@ghost ghost removed the tests are failing Do not merge until tests pass label Feb 13, 2022
poyea
poyea approved these changes Feb 13, 2022
View reviewed changes
arithmetic_analysis/in_static_equilibrium.py
@@ -13,9 +13,9 @@ def polar_force(
Resolves force along rectangular components.
(force, angle) => (force_x, force_y)
>>> polar_force(10, 45)
[7.0710678118654755, 7.071067811865475]
[7.071067811865477, 7.0710678118654755]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably explain in the numpy changelog.

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Feb 13, 2022
@cclauss cclauss merged commit 885580b into TheAlgorithms:master Feb 13, 2022
@cclauss cclauss deleted the mypy-yet-again branch February 13, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @poyea