Scrape anime and play episodes on browser without ads from terminal #5975

saptarshi1996 · 2022-02-01T21:11:01Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

…/Python into download-anime-url

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

web_programming/fetch_anime_and_play.py

ghost · 2022-02-01T21:11:15Z

web_programming/fetch_anime_and_play.py

+            )
+            chosen_anime = anime_list[anime_choice - 1]
+            print(
+                "You chose {}. Searching for episodes...".format(chosen_anime["title"])


As mentioned in the Contributing Guidelines, please do not use printf style formatting or str.format(). Use f-string instead to be more readable and efficient.

ghost · 2022-02-01T21:11:15Z

web_programming/fetch_anime_and_play.py

+            else:
+                print(f"Found {len(episode_list)} results: ")
+                for (i, episode) in enumerate(episode_list):
+                    print(("{}. {}").format(i + 1, episode["title"]))


As mentioned in the Contributing Guidelines, please do not use printf style formatting or str.format(). Use f-string instead to be more readable and efficient.

ghost · 2022-02-01T21:11:15Z

web_programming/fetch_anime_and_play.py

+                    input("\nChoose an episode by serial no: ").strip()
+                )
+                chosen_episode = episode_list[episode_choice - 1]
+                print("You chose {}. Searching...".format(chosen_episode["title"]))


As mentioned in the Contributing Guidelines, please do not use printf style formatting or str.format(). Use f-string instead to be more readable and efficient.

cclauss · 2022-02-01T21:14:02Z

web_programming/fetch_anime_and_play.py

@@ -0,0 +1,203 @@
+from urllib.error import HTTPError


Suggested change

from urllib.error import HTTPError

from requests.exceptions import HTTPError, RequestException

changed with from requests.exceptions import RequestException

cclauss · 2022-02-01T21:15:28Z

web_programming/fetch_anime_and_play.py

+
+        return anime_list
+
+    except (requests.exceptions.RequestException, HTTPError, TypeError) as e:


Suggested change

except (requests.exceptions.RequestException, HTTPError, TypeError) as e:

except (HTTPError, RequestException, TypeError) as e:

changed to RequestException

cclauss · 2022-02-01T21:16:57Z

web_programming/fetch_anime_and_play.py

+        [list]: [List of animes]
+    """
+
+    try:


try / except block should be just around critical areas of code. They should not be 30 lines long!!

removed the long try catches with critical ones

cclauss · 2022-02-01T21:19:50Z

web_programming/fetch_anime_and_play.py

+        KeyError,
+        NotFoundErr,
+        TypeError,
+        requests.exceptions.RequestException,


Long try / except blocks lead to many different exceptions which confuses the reader of the code. It also slows down debugging when one of them is raised.

removed multiple exceptions

saptarshi1996 · 2022-02-01T21:41:38Z

@cclauss . I have made the changes

cclauss · 2022-02-01T21:47:43Z

web_programming/fetch_anime_and_play.py

+    except RequestException as e:
+        raise e


There is no need to catch an Exception if you are only going to raise the same Exception unmodified.

ok. i've used response.raise_for_status() instead.

cclauss · 2022-02-01T21:57:01Z

web_programming/fetch_anime_and_play.py

+    for children in episode_page_li:
+        try:
+            if not isinstance(children, NavigableString):
+                episode_list.append(
+                    {
+                        "title": children.find("div", {"class": "name"}).text.replace(
+                            " ", ""
+                        ),
+                        "url": children.find("a")["href"],


It confuses the reader that children is plural yet these items are singular. It is easier to understand when each item is an episode...

Suggested change

for children in episode_page_li:

try:

if not isinstance(children, NavigableString):

episode_list.append(

{

"title": children.find("div", {"class": "name"}).text.replace(

" ", ""

),

"url": children.find("a")["href"],

for episode in episode_page_li:

try:

if not isinstance(episode, NavigableString):

episode_list.append(

{

"title": episode.find("div", {"class": "name"}).text.replace(

" ", ""

),

"url": episode.find("a")["href"],

for episode in episode_page_li:
for anime in anime_li:
Like this now

cclauss · 2022-02-01T21:59:29Z

web_programming/fetch_anime_and_play.py

+
+    """[summary]
+
+    This function will take an url and


Suggested change

This function will take an url and

Take an url and

cclauss · 2022-02-01T21:59:54Z

web_programming/fetch_anime_and_play.py

+
+    """[summary]
+
+    This function will take an url and


Suggested change

This function will take an url and

Take an url and

changed them

cclauss · 2022-02-01T22:01:04Z

web_programming/fetch_anime_and_play.py

+    except (ValueError, IndexError, TypeError) as e:
+        raise e


We can lose the try / except if we are not going to handle the errors.

removed the block.

cclauss · 2022-02-01T22:16:29Z

web_programming/fetch_anime_and_play.py

+    response = requests.get(
+        search_url, headers={"UserAgent": UserAgent().chrome}
+    )  # request the url.


Don't wrap a line just for a comment.

Suggested change

response = requests.get(

search_url, headers={"UserAgent": UserAgent().chrome}

) # request the url.

# request the url.

response = requests.get(search_url, headers={"UserAgent": UserAgent().chrome})

saptarshi1996 · 2022-02-01T23:05:31Z

Thank you @cclauss

saptarshi1996 added 4 commits February 2, 2022 02:26

fetch anime

1193036

Merge branch 'download-anime-url' of https://github.com/saptarshi1996…

40fe58a

…/Python into download-anime-url

formatted code

30c2d6c

fix format errors

c24a550

saptarshi1996 requested a review from cclauss as a code owner February 1, 2022 21:11

ghost added the require tests Tests [doctest/unittest/pytest] are required label Feb 1, 2022

ghost reviewed Feb 1, 2022

View reviewed changes

ghost added the awaiting reviews This PR is ready to be reviewed label Feb 1, 2022

fix bot reviews

bb3e821

ghost removed the require tests Tests [doctest/unittest/pytest] are required label Feb 1, 2022

cclauss requested changes Feb 1, 2022

View reviewed changes

ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Feb 1, 2022

pr review fixes

cdfffbc

ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Feb 1, 2022

saptarshi1996 requested a review from cclauss February 1, 2022 21:41

cclauss reviewed Feb 1, 2022

View reviewed changes

remove unussed exception

d5f33c5

saptarshi1996 requested a review from cclauss February 1, 2022 21:53

cclauss reviewed Feb 1, 2022

View reviewed changes

saptarshi1996 added 2 commits February 2, 2022 03:31

change var name

20d1b45

fix comments

9ee4e4e

saptarshi1996 requested a review from cclauss February 1, 2022 22:06

cclauss reviewed Feb 1, 2022

View reviewed changes

cclauss approved these changes Feb 1, 2022

View reviewed changes

ghost removed the awaiting reviews This PR is ready to be reviewed label Feb 1, 2022

cclauss merged commit d28ac64 into TheAlgorithms:master Feb 1, 2022

saptarshi1996 deleted the download-anime-url branch February 1, 2022 22:26

saptarshi1996 restored the download-anime-url branch February 1, 2022 22:26

saptarshi1996 deleted the download-anime-url branch February 1, 2022 22:26

saptarshi1996 restored the download-anime-url branch February 1, 2022 22:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scrape anime and play episodes on browser without ads from terminal #5975

Scrape anime and play episodes on browser without ads from terminal #5975

saptarshi1996 commented Feb 1, 2022

ghost left a comment

ghost Feb 1, 2022

ghost Feb 1, 2022

ghost Feb 1, 2022

cclauss Feb 1, 2022

saptarshi1996 Feb 1, 2022

cclauss Feb 1, 2022

saptarshi1996 Feb 1, 2022

cclauss Feb 1, 2022

saptarshi1996 Feb 1, 2022

cclauss Feb 1, 2022

saptarshi1996 Feb 1, 2022

saptarshi1996 commented Feb 1, 2022

cclauss Feb 1, 2022

saptarshi1996 Feb 1, 2022

cclauss Feb 1, 2022

saptarshi1996 Feb 1, 2022

cclauss Feb 1, 2022

cclauss Feb 1, 2022

saptarshi1996 Feb 1, 2022

cclauss Feb 1, 2022

saptarshi1996 Feb 1, 2022

cclauss Feb 1, 2022

saptarshi1996 commented Feb 1, 2022

	from urllib.error import HTTPError
	from requests.exceptions import HTTPError, RequestException


		return anime_list

		except (requests.exceptions.RequestException, HTTPError, TypeError) as e:

	except (requests.exceptions.RequestException, HTTPError, TypeError) as e:
	except (HTTPError, RequestException, TypeError) as e:

Scrape anime and play episodes on browser without ads from terminal #5975

Scrape anime and play episodes on browser without ads from terminal #5975

Conversation

saptarshi1996 commented Feb 1, 2022

Describe your change:

Checklist:

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saptarshi1996 commented Feb 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saptarshi1996 commented Feb 1, 2022