Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issues due to count #5725

Merged
merged 2 commits into from
Oct 31, 2021
Merged

Fix build issues due to count #5725

merged 2 commits into from
Oct 31, 2021

Conversation

Rohanrbharadwaj
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Oct 31, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 31, 2021
@Rohanrbharadwaj
Copy link
Contributor Author

Referred to https://medium.com/@ageitgey/yep-its-a-little-goofy-you-declare-defaultdict-types-like-this-90ac61025789

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 31, 2021
@cclauss cclauss merged commit 99cf2cc into TheAlgorithms:master Oct 31, 2021
@cclauss cclauss mentioned this pull request Oct 31, 2021
Closed
14 tasks
@Rohanrbharadwaj Rohanrbharadwaj deleted the patch-2 branch November 1, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rohanrbharadwaj @cclauss