Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved prime_numbers.py #5592

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Improved prime_numbers.py #5592

merged 4 commits into from
Oct 26, 2021

Conversation

Leoriem-code
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 25, 2021
@cclauss
Copy link
Member

cclauss commented Oct 25, 2021

Please add a timeit benchmark to prove which is faster.

@Leoriem-code
Copy link
Contributor Author

I did around 80 000 test, and here are the results:
slow

normal

fast

@cclauss
Copy link
Member

cclauss commented Oct 26, 2021

I increase the timeit number to 1_000_000. My results:

0.13780254199999975
0.09855987499999985
0.09820629199999997

0.13855433299999964
0.09545766600000016
0.095391416

0.1449954579999999
0.09700583299999999
0.09648933399999993

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2021
@cclauss cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 26, 2021
@cclauss cclauss merged commit 716beb3 into TheAlgorithms:master Oct 26, 2021
@Leoriem-code Leoriem-code deleted the improve-prime branch October 26, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants