Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magnitude and Angle of Vector #5225

Merged
merged 6 commits into from
Oct 12, 2021
Merged

Magnitude and Angle of Vector #5225

merged 6 commits into from
Oct 12, 2021

Conversation

AMANKANOJIYA
Copy link
Contributor

Describe your change:

Core function to find Magnitude and Angle of two Given Vector

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanations.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@AMANKANOJIYA
Magnitude and Angle
efca208 
Core function to find Magnitude and Angle of two Given Vector
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 11, 2021
cclauss
cclauss requested changes Oct 11, 2021
View reviewed changes
linear_algebra/src/lib.py Outdated
def magnitude(self) -> float:
'''
Magnitude of a Vector
'''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No doctest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add doctests for negative numbers and zero.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And use double quotes

@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 11, 2021
@AMANKANOJIYA
Magnitude and Angle with Doctest
2fc782e 
added Doctest to the functions
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 11, 2021
@AMANKANOJIYA
Copy link
Contributor Author

Added DocTest to the file

cclauss
cclauss reviewed Oct 11, 2021
View reviewed changes
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 11, 2021
cclauss
cclauss reviewed Oct 11, 2021
View reviewed changes
cclauss
cclauss reviewed Oct 11, 2021
View reviewed changes
AMANKANOJIYA and others added 4 commits October 11, 2021 17:59
@AMANKANOJIYA @cclauss
Update linear_algebra/src/lib.py
0350a9d 
Co-authored-by: Christian Clauss <cclauss@me.com>
@AMANKANOJIYA @cclauss
Update linear_algebra/src/lib.py
cde040f 
Co-authored-by: Christian Clauss <cclauss@me.com>
@AMANKANOJIYA
Changes done
02fc704 
and Magnitude and Angle Issues
@cclauss
black
ef01d09
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 12, 2021
cclauss
cclauss approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for doing this!

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2021
@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 12, 2021
@cclauss cclauss merged commit 1b0ac73 into TheAlgorithms:master Oct 12, 2021
@AMANKANOJIYA
Copy link
Contributor Author

Welcome. I will Love to contribute more to this Community

shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@AMANKANOJIYA @cclauss @shermanhui
Magnitude and Angle of Vector (TheAlgorithms#5225)
877c7d0 
* Magnitude and Angle 

Core function to find Magnitude and Angle of two Given Vector

* Magnitude and Angle with Doctest

added Doctest to the functions

* Update linear_algebra/src/lib.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update linear_algebra/src/lib.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Changes done 

and Magnitude and Angle Issues

* black

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rohanrbharadwaj Rohanrbharadwaj Rohanrbharadwaj left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AMANKANOJIYA @cclauss @Rohanrbharadwaj