Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding bin_to_hexadecimal #5156

Merged
merged 1 commit into from
Oct 25, 2021
Merged

adding bin_to_hexadecimal #5156

merged 1 commit into from
Oct 25, 2021

Conversation

franciscoperez2021
Copy link
Contributor

@franciscoperez2021 franciscoperez2021 commented Oct 8, 2021 •
edited
Loading

Describe your change:

Adding a new algorithms to convert binary to hexadecimal to participate in hacktoberfest 2021, #4996

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 8, 2021
@franciscoperez2021
Copy link
Contributor Author

@yoki31, I will appreciate if you can review this pull request to speed up and merge.

Thanks

Cheers,
F.P.

@franciscoperez2021
Copy link
Contributor Author

Hi @poyea ,

I would appreciate if you could review this this pull request, could you review it?

Thanks,
Regards,
Francisco Perez

@franciscoperez2021 franciscoperez2021 mentioned this pull request Oct 17, 2021
Closed
@poyea
Copy link
Member

poyea commented Oct 18, 2021

@franciscoperez2021 let's just follow https://github.com/TheAlgorithms/Python/blob/master/conversions/binary_to_octal.py for all the error messages / styles

@franciscoperez2021 franciscoperez2021 force-pushed the bin_to_hexadecimal_hacktoberfest branch 3 times, most recently from d5ea9a5 to db2f685 Compare October 18, 2021 20:24
@franciscoperez2021
Copy link
Contributor Author

franciscoperez2021 commented Oct 18, 2021 •
edited
Loading

Hi @poyea

I have already pushed a new commit with all things fixed but I don't understand your comment about the for loop. So, please could you clarify it?

Thanks,

Regards,
Francisco Perez

@ghost ghost added the tests are failing Do not merge until tests pass label Oct 19, 2021
@franciscoperez2021 franciscoperez2021 force-pushed the bin_to_hexadecimal_hacktoberfest branch from db2f685 to c75b88e Compare October 19, 2021 07:53
@franciscoperez2021 franciscoperez2021 force-pushed the bin_to_hexadecimal_hacktoberfest branch from c75b88e to 2878615 Compare October 19, 2021 08:21
@franciscoperez2021
Copy link
Contributor Author

Hi @poyea ,

Already, fixed all errors the last commit id 2878615 should work

Cheers,
F.P.

@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 19, 2021
@franciscoperez2021
Copy link
Contributor Author

Hi @poyea ,

All tests have been passed and all comments above have been fixed. Thus, please, could you review the PR?

Thanks,

Regards,
Francisco Perez

poyea
poyea approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 25, 2021
@poyea poyea merged commit 568c107 into TheAlgorithms:master Oct 25, 2021
@franciscoperez2021
Copy link
Contributor Author

Thank you @poyea !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscoperez2021 @poyea