Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] Fix type annotations for strings #4637

Merged
merged 4 commits into from
Aug 19, 2021
Merged

[mypy] Fix type annotations for strings #4637

merged 4 commits into from
Aug 19, 2021

Conversation

imp2002
Copy link
Member

@imp2002 imp2002 commented Aug 19, 2021

Related issue #4052

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Aug 19, 2021
@l3str4nge l3str4nge merged commit 20a4fdf into TheAlgorithms:master Aug 19, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 19, 2021
@imp2002 imp2002 deleted the fix-mypy-strings branch August 20, 2021 13:47
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@imp2002 @shermanhui
[mypy] Fix type annotations for strings (TheAlgorithms#4637)
0c23f30 
* Fix mypy error for can_string_be_rearranged_as_pal

* Fix mypy error for levenshtein_distance.py

* Fix mypy error for word_patterns.py

* Fix mypy error for word_occurrence.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imp2002 @l3str4nge