[mypy] Add/fix type annotations for similarity search in machine learning #4088
Access has been restricted
You have triggered a rate limit.
Please wait a few minutes before you try again;
in some cases this may take up to an hour.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
awaiting reviews
poyea
approved these changes
Jan 3, 2021
dhruvmanila
requested changes
Jan 4, 2021
| def similarity_search(dataset: np.ndarray, value_array: np.ndarray) -> list: | ||
| def similarity_search( | ||
| dataset: np.ndarray, value_array: np.ndarray | ||
| ) -> List[List[float]]: |
There was a problem hiding this comment.
The return type hint does not seem to be correct as per the given examples:
[[[0], 0.0]]
[[[0, 0, 0], 1.0]]
[[[0, 0, 0], 0.0], [[0, 0, 0], 1.0]]
Maybe:
List[List[Union[List[float], float]]]I would suggest changing the return data type but that is out of scope for this PR.
ghost
added
awaiting reviews
dhruvmanila
approved these changes
Jan 22, 2021
14 tasks
peRFectBeliever
pushed a commit
to peRFectBeliever/Python
that referenced
this pull request
Apr 1, 2021
…ning (TheAlgorithms#4088) * [mypy] Add/fix type annotations for similarity search in machine learning * fix annotation * fix annotation (Union) * isort
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
…ning (TheAlgorithms#4088) * [mypy] Add/fix type annotations for similarity search in machine learning * fix annotation * fix annotation (Union) * isort
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
…ning (TheAlgorithms#4088) * [mypy] Add/fix type annotations for similarity search in machine learning * fix annotation * fix annotation (Union) * isort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ mypy --strict machine_learning/similarity_search.py --ignore-missing-imports
Success: no issues found in 1 source file
Describe your change:
Related Issue: #4052
Checklist:
Fixes: #{$ISSUE_NO}.