Instagram Video and IGTV downloader

[Epic-R-R]

Download Video and IGTV from Instagram

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[ghost]

Pull Request Report

@Epic-R-R Hello! I'm a bot made to check all the pull request Python files. First of all, I want to say thank you for your time and interest in this project and for opening a pull request. There seems to be missing requirements in some of the Python files submitted in this pull request. Please read through the report and make the necessary changes. You can take a look at the relevant links provided after the report.

What are node paths? 🔽

The report contains headings and a checklist where the items are paths to the class/function/parameter where the requirement is missing. Node paths are double colon :: separated names and can be in any of the following format:

• Class path: [file_name]::[class_name]
• Function path: [file_name]::[function_name]
• Function parameter path: [file_name]::[function_name]::[parameter_name]
• Method path: [file_name]::[class_name]::[function_name]
• Method parameter path: [file_name]::[class_name]::[function_name]::[parameter_name]

Following functions require tests [doctest/unittest/pytest]:

• web_programming/instagram_video.py::get_video

Following function parameters require type hints:

• web_programming/instagram_video.py::get_video::link

Relevant links 🔽

• Contributing guidelines
• Project Euler solution guidelines
• Type hints
• doctest
• unittest
• pytest

[cclauss]

Requests has json builtin.

The first thing that I would do after running this would be to rename the file to something relevant. Would there be a way to parse a more useful file name out of the user input?

[dhruvmanila]

FYI, I am not a big fan of the way this code is written just to fool the bot to remove the require ... labels. Also, if possible please write tests as the code could break in a matter of months depending on the API used. Take a look at how I wrote it for fetch_github_info: https://github.com/TheAlgorithms/Python/blob/master/web_programming/test_fetch_github_info.py

[amaank404]

this is more of a command line tool, please implement the following things:

• function is used to get the data (with doctests, and typehints)
• no print or input function is used in function
• file is returned through function and not saved
• You can still have the input output (command line interface) in the if __name__ == "__main__" block

[amaank404]

Please make the following changes first then you can add the doctests (or you can leave them because it is a downloading proggram and doctest might not be possible here)

[Epic-R-R]

I Update the code but in pre-commit, I have some error in the download_video function.
I use isort and black on code and it's ok

[cclauss]

Nice!

[dhruvmanila]

So, no tests?

[Epic-R-R]

Great, thank you for Update the code

[amaank404]

Wow, the code lines shrank too much 😄

[cclauss]

;-). That’s what I do... https://github.com/cclauss/Ten-lines-or-less

[dhruvmanila]

Explicit is better than implicit. 😉

[cclauss]

What is implicit in this code?

[dhruvmanila]

Nothing, just putting this line out there :)

[cclauss]

Namespaces are one honking great idea -- let's do more of those!

[cclauss]

So, no tests?

As I wrote you before, web programming tests are difficult to write without mocking so that basically makes doctests a nonstarter. If someone would be willing to add tests to this or another web programming algorithm, then we could use that as a guide for future web programming contributors.

[dhruvmanila]

I will try to do that. In the meantime, if possible can you give a small glance to #3977 just to determine whether it's worth doing?

Also, I am in the middle of redesigning the parser for the bot and it will do more than just a comment. :)