Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qiskit: Add Quantum Half Adder #3405

Merged
merged 2 commits into from
Oct 17, 2020
Merged

Qiskit: Add Quantum Half Adder #3405

merged 2 commits into from
Oct 17, 2020

Conversation

abhishekjiitr
Copy link
Contributor

@abhishekjiitr abhishekjiitr commented Oct 17, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@abhishekjiitr
Copy link
Contributor Author

@cclauss can you review?

cclauss
cclauss approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good. Thanks for doing them.

But they seem far away from real-world problems. If we want readers to get interested in quantum computing, we need to solve problems that they can empathize with and get excited about. Can we tell a story about how some quantum algorithm is saving time or money or sick patients or reducing pollution?

We need to give readers reasons to reach for quantum algorithms.

@cclauss cclauss merged commit a88006d into TheAlgorithms:master Oct 17, 2020
@abhishekjiitr
Copy link
Contributor Author

@cclauss I completely agree with you, I will try to code up Deutsh-Josza as a step in this direction.
I added these initial programs to sort of build a gradual progression towards more complicated quantum algorithms.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@abhishekjiitr @stokhos
Qiskit: Add Quantum Half Adder (TheAlgorithms#3405)
556955c 
* Qiskit: Add Quantum Half Adder

* fixup! Format Python code with psf/black push

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@abhishekjiitr @peRFectBeliever
Qiskit: Add Quantum Half Adder (TheAlgorithms#3405)
bf5a5e7 
* Qiskit: Add Quantum Half Adder

* fixup! Format Python code with psf/black push

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@abhishekjiitr
Qiskit: Add Quantum Half Adder (TheAlgorithms#3405)
2fc165b 
* Qiskit: Add Quantum Half Adder

* fixup! Format Python code with psf/black push

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhishekjiitr @cclauss