Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest 2020 - coding style for project_euler problem 45 & 16 #3087

Merged
merged 8 commits into from
Oct 9, 2020
Merged

Hacktoberfest 2020 - coding style for project_euler problem 45 & 16 #3087

merged 8 commits into from
Oct 9, 2020

Conversation

fa1l
Copy link
Contributor

@fa1l fa1l commented Oct 9, 2020 •
edited
Loading

Describe your change:

Related to #2786

  • added link for problem

  • added solution function

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@dhruvmanila
Copy link
Member

dhruvmanila commented Oct 9, 2020 •
edited
Loading

Please fix two more directories if possible.

@fa1l fa1l changed the title Hacktoberfest 2020 - coding style for project_euler problem 45 Hacktoberfest 2020 - coding style for project_euler problem 45 & 16 Oct 9, 2020
@fa1l
Copy link
Contributor Author

fa1l commented Oct 9, 2020

Two more files will be enough? There's a race condition between PRs for problems and I don't want to make duplicates or ruin others PRs.

@dhruvmanila dhruvmanila merged commit 10fe9d9 into TheAlgorithms:master Oct 9, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@fa1l @dhruvmanila @stokhos
Coding style improvements for project_euler problem 45 & 16 (TheAlgor…
496cf48 
…ithms#3087)

* improvements for project euler task 45

* fixed documentation

* update pe_16/sol1.py

* update pe_16/sol2.py

* revert solution changes for sol1

* revert solution changes for sol2

* remove trailing spaces in sol1

* Update sol1.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@fa1l @dhruvmanila
Coding style improvements for project_euler problem 45 & 16 (TheAlgor…
2334624 
…ithms#3087)

* improvements for project euler task 45

* fixed documentation

* update pe_16/sol1.py

* update pe_16/sol2.py

* revert solution changes for sol1

* revert solution changes for sol2

* remove trailing spaces in sol1

* Update sol1.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fa1l @dhruvmanila