Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Euler 62 Solution #3029

Merged
merged 11 commits into from
Oct 15, 2020
Merged

Project Euler 62 Solution #3029

merged 11 commits into from
Oct 15, 2020

Conversation

peteryao7
Copy link
Contributor

@peteryao7 peteryao7 commented Oct 8, 2020 •
edited
Loading

Describe your change:

Adds a solution and explanation for Project Euler 62. Part of issue #2695.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@peteryao7 peteryao7 changed the title Project Euler 62 Solution Hacktoberfest: Project Euler 62 Solution Oct 8, 2020
@peteryao7 peteryao7 changed the title Hacktoberfest: Project Euler 62 Solution Hacktoberfest 2020: Project Euler 62 Solution Oct 8, 2020
@peteryao7
Copy link
Contributor Author

I'm not sure why there's a second Travis build running. It's been going for over 20 minutes now.

@peteryao7
Copy link
Contributor Author

Pushing a new commit seems to have fixed the problem.

@peteryao7 peteryao7 changed the title Hacktoberfest 2020: Project Euler 62 Solution Project Euler 62 Solution Oct 9, 2020
@peteryao7
Copy link
Contributor Author

Hi @dhruvmanila, it's been almost a week and my PRs haven't been reviewed yet. I know you're probably swamped with hundreds of open PRs right now, but please look at my solutions for problem 62 (here), 65, 70, and 206, and let me know if there are any issues I need to fix. Thank you :)

@dhruvmanila
Copy link
Member

Closing and re-opening the PR for Travis CI to rerun with a new configuration.

@dhruvmanila dhruvmanila reopened this Oct 15, 2020
dhruvmanila
dhruvmanila requested changes Oct 15, 2020
View reviewed changes
project_euler/problem_62/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_62/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_62/sol1.py Outdated Show resolved Hide resolved
@dhruvmanila
Copy link
Member

You opened 4 PRs at a time when we eplicitly mentioned to open only one PR at a time. If you cannot follow that, then please don't expect us to review all your PRs at one go just because you think it's more important than others.

@dhruvmanila dhruvmanila added awaiting changes A maintainer has requested changes to this PR require tests Tests [doctest/unittest/pytest] are required labels Oct 15, 2020
@peteryao7
Copy link
Contributor Author

You opened 4 PRs at a time when we eplicitly mentioned to open only one PR at a time. If you cannot follow that, then please don't expect us to review all your PRs at one go just because you think it's more important than others.

Got it. I saw other PRs made after mine that got reviewed and merged sooner, so I was concerned about getting skipped over.

I'll make the changes later tonight.

@peteryao7 peteryao7 requested a review from Kush1101 as a code owner October 15, 2020 03:19
@peteryao7
Copy link
Contributor Author

@dhruvmanila Finished the changes. Thanks again for getting back to me! I will make similar changes to my other 3 PRs so they look like this one.

@dhruvmanila dhruvmanila removed awaiting changes A maintainer has requested changes to this PR require tests Tests [doctest/unittest/pytest] are required labels Oct 15, 2020
@dhruvmanila
Copy link
Member

Yes, that would make it easy for us to review. Thank you for doing that :)

@peteryao7
Copy link
Contributor Author

@dhruvmanila Answer test case removed.

dhruvmanila
dhruvmanila approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution!

@dhruvmanila dhruvmanila merged commit 671ab1d into TheAlgorithms:master Oct 15, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@peteryao7 @stokhos
Project Euler 62 Solution (TheAlgorithms#3029)
145b255 
* Add solution for Project Euler 62

* Add doctests and annotate function params and return values for get_digits()

* Add extra newline between functions to fix flake8 errors

* Add extra newlines between function names

* Add missing return type for solution()

* Remove parenthesis from if statement

* Remove parentheses from while loop

* Add to explanation and fix second Travis build

* Compress get_digits(), add tests for solution(), add fstring and positional arg for solution()

* Remove input param when calling solution()

* Remove test case for the answer
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@peteryao7
Project Euler 62 Solution (TheAlgorithms#3029)
3c36849 
* Add solution for Project Euler 62

* Add doctests and annotate function params and return values for get_digits()

* Add extra newline between functions to fix flake8 errors

* Add extra newlines between function names

* Add missing return type for solution()

* Remove parenthesis from if statement

* Remove parentheses from while loop

* Add to explanation and fix second Travis build

* Compress get_digits(), add tests for solution(), add fstring and positional arg for solution()

* Remove input param when calling solution()

* Remove test case for the answer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peteryao7 @dhruvmanila