Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest 2020 - coding style with default argument for project_euler problem 27 #3020

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Hacktoberfest 2020 - coding style with default argument for project_euler problem 27 #3020

merged 2 commits into from
Oct 8, 2020

Conversation

nstoik
Copy link
Contributor

@nstoik nstoik commented Oct 8, 2020

Describe your change:

Add problem url and default values to solution() function

Related to #2786

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@dhruvmanila dhruvmanila merged commit e242485 into TheAlgorithms:master Oct 8, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@nstoik @dhruvmanila @stokhos
Coding style with default argument for project_euler problem 27 (TheA…
1043ee6 
…lgorithms#3020)

* add default arguments and problem url

* Update and rename problem_27_sol1.py to sol1.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@nstoik @dhruvmanila
Coding style with default argument for project_euler problem 27 (TheA…
1dc25c5 
…lgorithms#3020)

* add default arguments and problem url

* Update and rename problem_27_sol1.py to sol1.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstoik @dhruvmanila