Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add style improvements for Project Euler problem 8 #3001

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Add style improvements for Project Euler problem 8 #3001

merged 1 commit into from
Oct 8, 2020

Conversation

archaengel
Copy link
Contributor

Continuing #2786

  • Add default argument values
  • Add type hints
  • Expand variable names
  • Add doctest or str_eval

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.

dhruvmanila
dhruvmanila approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thank you for your contribution!

@dhruvmanila dhruvmanila merged commit f3fe29c into TheAlgorithms:master Oct 8, 2020
@dhruvmanila dhruvmanila added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 8, 2020
@archaengel
Copy link
Contributor Author

Thanks for taking the time to review!

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@archaengel @stokhos
Add style improvements to Project Euler problem 8 (TheAlgorithms#3001)
77bab35
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@archaengel
Add style improvements to Project Euler problem 8 (TheAlgorithms#3001)
286cfe5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archaengel @dhruvmanila