Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints and default args for Project Euler problem 5 #2982

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Add type hints and default args for Project Euler problem 5 #2982

merged 3 commits into from
Oct 8, 2020

Conversation

sgalpha01
Copy link
Contributor

Continuing #2786

  • Added type hints
  • Added default argument values for validate_solutions script

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All function parameters and return values are annotated with Python type hints.

dhruvmanila
dhruvmanila approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@dhruvmanila dhruvmanila merged commit 6a5a022 into TheAlgorithms:master Oct 8, 2020
@sgalpha01 sgalpha01 deleted the patch-project_euler-problem_5 branch October 8, 2020 05:34
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@sgalpha01 @dhruvmanila @stokhos
Add type hints and default args for Project Euler problem 5 (TheAlgor…
7a90a36 
…ithms#2982)

* add type hints and default args for problem 5

* Update sol1.py

* Update sol2.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@sgalpha01 @dhruvmanila
Add type hints and default args for Project Euler problem 5 (TheAlgor…
ba91224 
…ithms#2982)

* add type hints and default args for problem 5

* Update sol1.py

* Update sol2.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgalpha01 @dhruvmanila