Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest 2020 - Style Improvements for project_euler/problem_26 #2958

Merged
merged 12 commits into from
Oct 8, 2020
Merged

Hacktoberfest 2020 - Style Improvements for project_euler/problem_26 #2958

merged 12 commits into from
Oct 8, 2020

Conversation

nstoik
Copy link
Contributor

@nstoik nstoik commented Oct 7, 2020

Describe your change:

Style and testing improvements for Project Euler problem 26

  • add completed problem description
  • add solution() function to pass tests in travis-ci
  • add type hints and default argument to solution() function
  • corrected invocation function of sol1.py as per the Contribution guide

Related to: #2786

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

dhruvmanila
dhruvmanila requested changes Oct 7, 2020
View reviewed changes
project_euler/problem_26/sol1.py Outdated Show resolved Hide resolved
dhruvmanila
dhruvmanila approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@dhruvmanila dhruvmanila added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 8, 2020
@dhruvmanila dhruvmanila merged commit ef53bbd into TheAlgorithms:master Oct 8, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@nstoik @stokhos
Style Improvements for project_euler/problem_26 (TheAlgorithms#2958)
b69b6f1 
* add typehints and docstrings

* add typehint and default value

* add typehint and default value. Removed unused variable.

* do not modifiy the given solution

* add doctests

* update sol1 after running black

* add typehint, docstring, and doctest

* update sol2 after running black

* add full problem statement and solution function with typehint and doctest

* renamed original function instead of adding new one

* don't alter original solution
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@nstoik
Style Improvements for project_euler/problem_26 (TheAlgorithms#2958)
40b7390 
* add typehints and docstrings

* add typehint and default value

* add typehint and default value. Removed unused variable.

* do not modifiy the given solution

* add doctests

* update sol1 after running black

* add typehint, docstring, and doctest

* update sol2 after running black

* add full problem statement and solution function with typehint and doctest

* renamed original function instead of adding new one

* don't alter original solution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstoik @dhruvmanila