Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest 2020: Added computer vision algorithm #2946

Merged
merged 5 commits into from
Oct 16, 2020
Merged

Hacktoberfest 2020: Added computer vision algorithm #2946

merged 5 commits into from
Oct 16, 2020

Conversation

TanayKarve
Copy link
Contributor

@TanayKarve TanayKarve commented Oct 6, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@sharpblade4
Copy link
Contributor

@TanayKarve you can optimize it in magnitudes by using numpy vectorian oprerations instead of python for loops

@TanayKarve
Copy link
Contributor Author

TanayKarve commented Oct 7, 2020 •
edited
Loading

@sharpblade4 yes i was planning to do it, however wanted to write this code in pure python, thus avoiding any dependencies. what do you think?

TanayKarve
TanayKarve commented Oct 8, 2020
View reviewed changes
Copy link
Contributor Author

@TanayKarve TanayKarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoiding numpy to make this implement in pure python.

@TanayKarve TanayKarve changed the title Added computer vision algorithm Hacktoberfest 2020: Added computer vision algorithm Oct 9, 2020
@TanayKarve
Copy link
Contributor Author

@sharpblade4 sorry to disturb you, but its been a week, can you please accept this PR?

@sharpblade4
Copy link
Contributor

@TanayKarve sorry for confusing you, I'm just another contributer - not an member of TheAlgorithms/Python.

cclauss
cclauss requested changes Oct 16, 2020
View reviewed changes
computer_vision/meanthreshold.py
Comment on lines +14 to +20
mean = 0
pixels = image.load()
for i in range(width):
for j in range(height):
pixel = pixels[j, i]
mean += pixel
mean //= width * height
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mean = 0
pixels = image.load()
for i in range(width):
for j in range(height):
pixel = pixels[j, i]
mean += pixel
mean //= width * height
total = sum(sum(pixel for pixel in row) for row in image.load())
mean = total // (width * height)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I tried using list builder comprehension initially. However image.load() returns a PixelAccess object which according to the documentation is not Iterable. Thus when running this code the following exception is thrown:
TypeError: 'PixelAccess' object is not iterable

TanayKarve and others added 2 commits October 16, 2020 18:34
@TanayKarve @cclauss
Update computer_vision/meanthreshold.py
95109c1 
Verified this part works, thanks.

Co-authored-by: Christian Clauss <cclauss@me.com>
@TanayKarve @cclauss
Update computer_vision/meanthreshold.py
a6a866e 
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thanks.

@cclauss cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 16, 2020
@cclauss cclauss merged commit fc98961 into TheAlgorithms:master Oct 16, 2020
@TanayKarve TanayKarve deleted the patch-1 branch October 16, 2020 13:18
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@TanayKarve @cclauss @stokhos
Hacktoberfest 2020: Added computer vision algorithm (TheAlgorithms#2946)
3cf8c10 
* Create meanthresholding.py

* Rename meanthresholding.py to meanthreshold.py

* Update meanthreshold.py

* Update computer_vision/meanthreshold.py

Verified this part works, thanks.

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update computer_vision/meanthreshold.py

Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: Christian Clauss <cclauss@me.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@TanayKarve @cclauss @peRFectBeliever
Hacktoberfest 2020: Added computer vision algorithm (TheAlgorithms#2946)
c965366 
* Create meanthresholding.py

* Rename meanthresholding.py to meanthreshold.py

* Update meanthreshold.py

* Update computer_vision/meanthreshold.py

Verified this part works, thanks.

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update computer_vision/meanthreshold.py

Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: Christian Clauss <cclauss@me.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@TanayKarve @cclauss
Hacktoberfest 2020: Added computer vision algorithm (TheAlgorithms#2946)
9f90f5b 
* Create meanthresholding.py

* Rename meanthresholding.py to meanthreshold.py

* Update meanthreshold.py

* Update computer_vision/meanthreshold.py

Verified this part works, thanks.

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update computer_vision/meanthreshold.py

Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TanayKarve @sharpblade4 @cclauss