Update doubly_linked_list.py #2573

akashgkrishnan · 2020-10-01T07:38:44Z

Update the implementation of linked list
made changes for optimizing
added more helper methods
used new variable names and function names

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

Update the implementation of linked list made changes for optimizing added more helper methods used new variable names and function names

removed comments

spamegg1 · 2020-10-01T08:06:45Z

@Property
def is_empty(self):
def is_empty(self):
return self.head is None
Error: Process completed with exit code 1.

Add a newline at the end of the file.

akashgkrishnan · 2020-10-01T09:41:13Z

can someone help me with why is it getting failed in the pre-commit pull request

akashgkrishnan · 2020-10-01T10:53:50Z

@spamegg1 i have done the same but it still is failing the checks
can you confirm why
and Can you please review the PR and let me know if anything needs to be changed so i can do them as well
Thanks in advance

Updated the complete linked list implementation

akashgkrishnan · 2020-10-13T13:35:46Z

@spamegg1 @dhruvmanila is there something more needs to be done in this PR?

akashgkrishnan · 2020-10-15T18:11:11Z

@cclauss hi sir can you review these changes?

cclauss · 2020-10-15T18:37:04Z

data_structures/linked_list/doubly_linked_list.py



-class LinkedList:
-    """


Why remove all these doctests?!?

@cclauss I had removed the previous doc test as I had completely changed the implementation. Apologies for that
I have updated the doc test with a set of new test cases and added in much more cases
Kindly review the new changes submitted for the Dubly linked List

Some functions are intentionally made of O(N) time complexity to provide a more user-friendly output on the console.
besides most functions are working in O(1) time complexity

Kindly update in case of furthermore changes are required

New Implementation Added in new doc test cases as per new implementation.

Fixed pre commit fails for PR Added in more test cases deleted the unwanted comments

updated the quotes(pre-commit fail)

Update quotes to fix pre-commit fails

cclauss · 2020-10-16T06:02:33Z

data_structures/linked_list/doubly_linked_list.py

+        return False
+
+    def get_head_data(self):
+        if self.head:


Suggested change

if self.head:

return self.head.data if self.head else None

Same with get_tail_data()

cclauss · 2020-10-16T06:05:29Z

data_structures/linked_list/doubly_linked_list.py

@@ -107,6 +125,8 @@ def delete_value(self, value):
                self.tail = self.tail.previous

            self.remove_node_pointers(node)
+        else:


The function signature does not say that this function returns a string. My sense is that we should raise an exception.

cclauss · 2020-10-16T06:12:38Z

data_structures/linked_list/doubly_linked_list.py

@@ -33,6 +33,24 @@ def __str__(self):
            current = current.next
        return "<-->".join(str(node) for node in nodes)


I find the "<—>" notation to be a lot of visual clutter. Why not just add an .__iter__() method and then return str(list(self))?

Hi sir,
I have added in a linked list iterator class for iterating over the linked list
and removed the <--> representation.

However, I have left the str(self) same and just removed the <--> from the string as
this would keep visualizing the linked list if someone wants to visualize the data in the Linked list while debugging as opposed to the memory address that it spits out

I had previously used the <--> representation as I thought it would make the links between nodes more clear

@cclauss I have made the changes

Update Doubly LinkedList created Linked List iterator class Removed the <--> string earlier used to specify link in the linked list added few more getter methods Added type hints

cclauss · 2020-10-16T11:16:51Z

data_structures/linked_list/doubly_linked_list.py

-    >>> for value in range(1,10):
-    ...    new_linked_list_2.insert(value=value)
-    >>> print(new_linked_list_2)


Let's not lose this test! We want a test of a linked list that is longer than one element.

Added in more test cases as requested

akashgkrishnan · 2020-10-16T11:41:41Z

@cclauss added the suggested testcase

cclauss · 2020-10-16T12:22:32Z

Let's do this. Please change the filename to doubly_linked_list_two.py and we can keep two different implementations of this data structure.

doubly_linked_list_two

akashgkrishnan · 2020-10-16T12:37:56Z

@cclauss renamed the filename as requested

cclauss · 2020-10-16T12:38:11Z

;-) Let's not delete the current implementation.

akashgkrishnan · 2020-10-16T12:50:02Z

@cclauss I'm new to this so spare me if I'm being too dumb. but I'm not sure how to rename my implementation to dll2
and maintain the existing file as is
since I had updated the same.
cause I had updated the previous file

cclauss · 2020-10-16T12:55:13Z

OK. Can you undelete the dll.py?

cclauss · 2020-10-16T12:57:51Z

If not, then copy dll2 to a new pull request that refers to #2573 and then close this PR.

TheAlgorithms#2573 the second implementation of the Doubly linked list

akashgkrishnan · 2020-10-16T13:08:59Z

@cclauss new PR created at #3380
closing this PR

#2573 the second implementation of the Doubly linked list

TheAlgorithms#2573 the second implementation of the Doubly linked list

akashgkrishnan added 2 commits October 1, 2020 13:08

Update doubly_linked_list.py

2e54707

Update the implementation of linked list made changes for optimizing added more helper methods used new variable names and function names

Update doubly_linked_list.py

44e105f

removed comments

akashgkrishnan added 2 commits October 1, 2020 14:05

Update doubly_linked_list.py

efc1a11

Update doubly_linked_list.py

8929b5b

Update doubly_linked_list.py

e934b9a

Updated the complete linked list implementation

cclauss reviewed Oct 15, 2020

View reviewed changes

akashgkrishnan added 4 commits October 16, 2020 07:25

Update the doubly lnked list file

69180f7

New Implementation Added in new doc test cases as per new implementation.

New DLL implementation

ad17f04

Fixed pre commit fails for PR Added in more test cases deleted the unwanted comments

Update doubly_linked_list.py

e5d25e4

updated the quotes(pre-commit fail)

Update doubly_linked_list.py

0a12a82

Update quotes to fix pre-commit fails

cclauss requested changes Oct 16, 2020

View reviewed changes

Updated doubly linked list

2d947c1

Update Doubly LinkedList created Linked List iterator class Removed the <--> string earlier used to specify link in the linked list added few more getter methods Added type hints

cclauss reviewed Oct 16, 2020

View reviewed changes

Update doubly_linked_list.py

f7b2e99

Added in more test cases as requested

Rename doubly_linked_list.py to doubly_linked_list_two.py

57934ba

doubly_linked_list_two

akashgkrishnan added a commit to akashgkrishnan/Python that referenced this pull request Oct 16, 2020

New doubly linkedlist PR: pull/2573

d22028b

TheAlgorithms#2573 the second implementation of the Doubly linked list

akashgkrishnan mentioned this pull request Oct 16, 2020

New doubly linkedlist PR: pull/2573 #3380

Merged

14 tasks

akashgkrishnan closed this Oct 16, 2020

cclauss pushed a commit that referenced this pull request Oct 16, 2020

New doubly linkedlist PR: pull/2573 (#3380)

c33b683

#2573 the second implementation of the Doubly linked list

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021

New doubly linkedlist PR: pull/2573 (TheAlgorithms#3380)

744c452

TheAlgorithms#2573 the second implementation of the Doubly linked list

peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021

New doubly linkedlist PR: pull/2573 (TheAlgorithms#3380)

d939324

TheAlgorithms#2573 the second implementation of the Doubly linked list

Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021

New doubly linkedlist PR: pull/2573 (TheAlgorithms#3380)

c809e84

TheAlgorithms#2573 the second implementation of the Doubly linked list

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update doubly_linked_list.py #2573

Update doubly_linked_list.py #2573

akashgkrishnan commented Oct 1, 2020 •

edited

Loading

spamegg1 commented Oct 1, 2020 •

edited

Loading

akashgkrishnan commented Oct 1, 2020

akashgkrishnan commented Oct 1, 2020

akashgkrishnan commented Oct 13, 2020

akashgkrishnan commented Oct 15, 2020

cclauss Oct 15, 2020 •

edited

Loading

akashgkrishnan Oct 16, 2020

cclauss Oct 16, 2020

cclauss Oct 16, 2020

cclauss Oct 16, 2020

akashgkrishnan Oct 16, 2020

cclauss Oct 16, 2020

akashgkrishnan commented Oct 16, 2020

cclauss commented Oct 16, 2020

akashgkrishnan commented Oct 16, 2020

cclauss commented Oct 16, 2020

akashgkrishnan commented Oct 16, 2020

cclauss commented Oct 16, 2020

cclauss commented Oct 16, 2020 •

edited

Loading

akashgkrishnan commented Oct 16, 2020

		@@ -33,6 +33,24 @@ def __str__(self):
		current = current.next
		return "<-->".join(str(node) for node in nodes)

Update doubly_linked_list.py #2573

Update doubly_linked_list.py #2573

Conversation

akashgkrishnan commented Oct 1, 2020 • edited Loading

Describe your change:

Checklist:

spamegg1 commented Oct 1, 2020 • edited Loading

akashgkrishnan commented Oct 1, 2020

akashgkrishnan commented Oct 1, 2020

akashgkrishnan commented Oct 13, 2020

akashgkrishnan commented Oct 15, 2020

cclauss Oct 15, 2020 • edited Loading

Choose a reason for hiding this comment

akashgkrishnan Oct 16, 2020

Choose a reason for hiding this comment

cclauss Oct 16, 2020

Choose a reason for hiding this comment

cclauss Oct 16, 2020

Choose a reason for hiding this comment

cclauss Oct 16, 2020

Choose a reason for hiding this comment

akashgkrishnan Oct 16, 2020

Choose a reason for hiding this comment

cclauss Oct 16, 2020

Choose a reason for hiding this comment

akashgkrishnan commented Oct 16, 2020

cclauss commented Oct 16, 2020

akashgkrishnan commented Oct 16, 2020

cclauss commented Oct 16, 2020

akashgkrishnan commented Oct 16, 2020

cclauss commented Oct 16, 2020

cclauss commented Oct 16, 2020 • edited Loading

akashgkrishnan commented Oct 16, 2020

akashgkrishnan commented Oct 1, 2020 •

edited

Loading

spamegg1 commented Oct 1, 2020 •

edited

Loading

cclauss Oct 15, 2020 •

edited

Loading

cclauss commented Oct 16, 2020 •

edited

Loading