Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create vector3_for_2d_rendering.py #2496

Merged
merged 21 commits into from
Sep 28, 2020
Merged

Create vector3_for_2d_rendering.py #2496

merged 21 commits into from
Sep 28, 2020

Conversation

amaank404
Copy link
Contributor

@amaank404 amaank404 commented Sep 27, 2020 •
edited
Loading

Edited for passing travis test

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@amaank404
Create vector3_for_2d_rendering.py
9590d36 
Edited for passing travis test
@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 36d37fe0-007b-11eb-a257-6fde496095bb

@amaank404
Copy link
Contributor Author

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 36d37fe0-007b-11eb-a257-6fde496095bb

now i am done

@amaank404
Copy link
Contributor Author

please review my pull request

@amaank404
Update vector3_for_2d_rendering.py
d9fcc66 
Compressed the line 19 to 28 into 19 to 21
@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d1eeb870-014b-11eb-9be6-0d9634a5fbe7

@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9c7a9f40-0152-11eb-9be6-0d9634a5fbe7

@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e07a4e70-0152-11eb-9be6-0d9634a5fbe7

@cclauss
Copy link
Member

cclauss commented Sep 28, 2020

https://travis-ci.com/github/TheAlgorithms/Python/jobs/391659513#L252-L263

@amaank404
Update vector3_for_2d_rendering.py
ccb6c9f 
completly corrected pep8 errors using Pycharm IDE
@amaank404
Copy link
Contributor Author

Edited code to get approved

@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f6b7dc10-0153-11eb-9be6-0d9634a5fbe7

@amaank404
Copy link
Contributor Author

editing

@amaank404
Copy link
Contributor Author

please review it

@amaank404 @dhruvmanila
Update graphics/vector3_for_2d_rendering.py
9975733 
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
@amaank404 @dhruvmanila
Update graphics/vector3_for_2d_rendering.py
022f7d5 
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
@amaank404 @dhruvmanila
Update graphics/vector3_for_2d_rendering.py
7b13ddc 
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 42fdb2f0-0156-11eb-9be6-0d9634a5fbe7

@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9d27f970-0156-11eb-9be6-0d9634a5fbe7

@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ce7ce940-0156-11eb-9be6-0d9634a5fbe7

@amaank404
Copy link
Contributor Author

done and approved by travis

cclauss
cclauss requested changes Sep 28, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your perseverance we will get this one merged soon.

graphics/vector3_for_2d_rendering.py Outdated Show resolved Hide resolved
graphics/vector3_for_2d_rendering.py Show resolved Hide resolved
graphics/vector3_for_2d_rendering.py Outdated Show resolved Hide resolved
graphics/vector3_for_2d_rendering.py Outdated Show resolved Hide resolved
graphics/vector3_for_2d_rendering.py Show resolved Hide resolved
graphics/vector3_for_2d_rendering.py Show resolved Hide resolved
graphics/vector3_for_2d_rendering.py Outdated Show resolved Hide resolved
graphics/vector3_for_2d_rendering.py Show resolved Hide resolved
amaank404 and others added 4 commits September 28, 2020 13:12
@amaank404
Update vector3_for_2d_rendering.py
1bad0cc
@amaank404 @cclauss
Update graphics/vector3_for_2d_rendering.py
a098a17 
Co-authored-by: Christian Clauss <cclauss@me.com>
@amaank404 @cclauss
Update graphics/vector3_for_2d_rendering.py
b2fee5d 
Co-authored-by: Christian Clauss <cclauss@me.com>
@amaank404 @cclauss
Apply suggestions from code review
fe96c7f 
Co-authored-by: Christian Clauss <cclauss@me.com>
@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 66f0a560-015f-11eb-9be6-0d9634a5fbe7

@amaank404
Update vector3_for_2d_rendering.py
ff55531 
Added A few extra names to __author__ 😄
@amaank404
Update vector3_for_2d_rendering.py
c5f6164 
Used Pycharm to fix PEP8 errors, doctest errors
@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 07eef0c0-0160-11eb-9be6-0d9634a5fbe7

@amaank404
Update vector3_for_2d_rendering.py
f5e9d4e 
Added enough doctests
@amaank404
Copy link
Contributor Author

It is very hard work to comply with all the requirements 😫. But still i am happy for contributions 😄

@amaank404
Copy link
Contributor Author

please review

@amaank404 amaank404 requested a review from cclauss September 28, 2020 08:48
amaank404
amaank404 commented Sep 28, 2020
View reviewed changes
Copy link
Contributor Author

@amaank404 amaank404 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done tests, added doctests, requested changes done

@amaank404 @cclauss
Update graphics/vector3_for_2d_rendering.py
44404ef 
Co-authored-by: Christian Clauss <cclauss@me.com>
@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e08d1450-016c-11eb-9be6-0d9634a5fbe7

cclauss
cclauss approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for doing this.

@cclauss cclauss merged commit 1b637ba into TheAlgorithms:master Sep 28, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@amaank404 @dhruvmanila
@cclauss @stokhos
Create vector3_for_2d_rendering.py (TheAlgorithms#2496)
d77f2a0 
* Create vector3_for_2d_rendering.py

Edited for passing travis test

* Delete vector3_for_2d_rendering.py

* Create vector3_for_2d_rendering.py

* Update vector3_for_2d_rendering.py

Compressed the line 19 to 28 into 19 to 21

* Update vector3_for_2d_rendering.py

* Update vector3_for_2d_rendering.py

* Update vector3_for_2d_rendering.py

completly corrected pep8 errors using Pycharm IDE

* Update vector3_for_2d_rendering.py

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>

* Update vector3_for_2d_rendering.py

* Update vector3_for_2d_rendering.py

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Apply suggestions from code review

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update vector3_for_2d_rendering.py

Added A few extra names to __author__ 😄

* Update vector3_for_2d_rendering.py

Used Pycharm to fix PEP8 errors, doctest errors

* Update vector3_for_2d_rendering.py

Added enough doctests

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Remove second main()

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@amaank404 @dhruvmanila @cclauss
Create vector3_for_2d_rendering.py (TheAlgorithms#2496)
78e5cc2 
* Create vector3_for_2d_rendering.py

Edited for passing travis test

* Delete vector3_for_2d_rendering.py

* Create vector3_for_2d_rendering.py

* Update vector3_for_2d_rendering.py

Compressed the line 19 to 28 into 19 to 21

* Update vector3_for_2d_rendering.py

* Update vector3_for_2d_rendering.py

* Update vector3_for_2d_rendering.py

completly corrected pep8 errors using Pycharm IDE

* Update vector3_for_2d_rendering.py

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Dhruv <dhruvmanila@gmail.com>

* Update vector3_for_2d_rendering.py

* Update vector3_for_2d_rendering.py

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Apply suggestions from code review

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update vector3_for_2d_rendering.py

Added A few extra names to __author__ 😄

* Update vector3_for_2d_rendering.py

Used Pycharm to fix PEP8 errors, doctest errors

* Update vector3_for_2d_rendering.py

Added enough doctests

* Update graphics/vector3_for_2d_rendering.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Remove second main()

Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amaank404 @TravisBuddy @cclauss @dhruvmanila