Skip to content

Reduce complexity linear_discriminant_analysis.#2452

Merged
dhruvmanila merged 8 commits intoTheAlgorithms:masterfrom
NumberPiOso:discriminant
Nov 11, 2020
Merged

Reduce complexity linear_discriminant_analysis.#2452
dhruvmanila merged 8 commits intoTheAlgorithms:masterfrom
NumberPiOso:discriminant

Conversation

@NumberPiOso
Copy link
Contributor

@NumberPiOso NumberPiOso commented Sep 19, 2020 •
edited
Loading

Tracking issue #2128

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • [ X All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Not really know how to create doctests for this kind of input functions.

@TravisBuddy
Copy link

TravisBuddy commented Sep 19, 2020

Hey @NumberPiOso,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: bde32920-fabf-11ea-8017-3168cf2e728c

@stale
Copy link

stale bot commented Oct 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Oct 22, 2020
@NumberPiOso
Copy link
Contributor Author

NumberPiOso commented Oct 27, 2020 •
edited
Loading

How do I get for someone to review this?

dhruvmanila
dhruvmanila requested changes Nov 10, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long, just a few small changes and this is good to go.

@dhruvmanila dhruvmanila added awaiting changes A maintainer has requested changes to this PR and removed stale Used to mark an issue or pull request stale. labels Nov 10, 2020
@dhruvmanila dhruvmanila reopened this Nov 10, 2020
@dhruvmanila dhruvmanila added the tests are failing Do not merge until tests pass label Nov 10, 2020
@NumberPiOso @dhruvmanila
Update machine_learning/linear_discriminant_analysis.py
f772d45 
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
@NumberPiOso
Copy link
Contributor Author

NumberPiOso commented Nov 10, 2020

@dhruvmanila

I just get one check from the Travis CI system, nothing from pre-commit.

Does this mean that it is good to go or that something is bad?

@dhruvmanila
Copy link
Member

dhruvmanila commented Nov 10, 2020 •
edited
Loading

Your branch is based off on a very old commit, the psf/black automated action is deprecated. Also, do not start the workflow runs on your forked copy as some action might be automated which will make commits to your branch and that will come in this pull request as well.

Always update your fork copy to keep in sync with the main repository. If you want to make a pull request, make a branch from the latest copy and then make your changes in that branch.

The branch this PR based off is around 200 commits behind the master branch of this repository.

@NumberPiOso
Copy link
Contributor Author

NumberPiOso commented Nov 10, 2020

Yes I get it, I suppose I always start the branches from the lastest commit.

But this pull request has been open since 19 September, almost two months, so I guess this explains why it is 200 commits behind.

If it is better to start another pull request cherry picking this changes or something let me know.

@dhruvmanila
Copy link
Member

dhruvmanila commented Nov 11, 2020

I think rebasing should be enough, if that won't work then try cherry-picking otherwise another PR seems like the easiest option :)

@dhruvmanila dhruvmanila removed tests are failing Do not merge until tests pass awaiting changes A maintainer has requested changes to this PR labels Nov 11, 2020
dhruvmanila
dhruvmanila approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to go. Thank you for your contribution! And sorry for the late review.

@dhruvmanila dhruvmanila merged commit 4851942 into TheAlgorithms:master Nov 11, 2020
@NumberPiOso NumberPiOso deleted the discriminant branch November 12, 2020 16:05
@NumberPiOso
Copy link
Contributor Author

NumberPiOso commented Nov 12, 2020

Thank you for the review.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@NumberPiOso @dhruvmanila @stokhos
Reduce complexity linear_discriminant_analysis. (TheAlgorithms#2452)
087a450 
* Reduce complexity linear_discriminant_analysis.

* Fix whitespace

* Update machine_learning/linear_discriminant_analysis.py

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>

* fixup! Format Python code with psf/black push

* Fix format to surpass pre-commit tests

* updating DIRECTORY.md

* Update machine_learning/linear_discriminant_analysis.py

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>

* fixup! Format Python code with psf/black push

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@NumberPiOso @dhruvmanila @peRFectBeliever
Reduce complexity linear_discriminant_analysis. (TheAlgorithms#2452)
d7b5806 
* Reduce complexity linear_discriminant_analysis.

* Fix whitespace

* Update machine_learning/linear_discriminant_analysis.py

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>

* fixup! Format Python code with psf/black push

* Fix format to surpass pre-commit tests

* updating DIRECTORY.md

* Update machine_learning/linear_discriminant_analysis.py

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>

* fixup! Format Python code with psf/black push

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@NumberPiOso @dhruvmanila
Reduce complexity linear_discriminant_analysis. (TheAlgorithms#2452)
c610899 
* Reduce complexity linear_discriminant_analysis.

* Fix whitespace

* Update machine_learning/linear_discriminant_analysis.py

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>

* fixup! Format Python code with psf/black push

* Fix format to surpass pre-commit tests

* updating DIRECTORY.md

* Update machine_learning/linear_discriminant_analysis.py

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>

* fixup! Format Python code with psf/black push

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@NumberPiOso @dhruvmanila @shermanhui
Reduce complexity linear_discriminant_analysis. (TheAlgorithms#2452)
08e4573 
* Reduce complexity linear_discriminant_analysis.

* Fix whitespace

* Update machine_learning/linear_discriminant_analysis.py

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>

* fixup! Format Python code with psf/black push

* Fix format to surpass pre-commit tests

* updating DIRECTORY.md

* Update machine_learning/linear_discriminant_analysis.py

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>

* fixup! Format Python code with psf/black push

Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NumberPiOso @TravisBuddy @dhruvmanila