Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #2378

Merged
merged 6 commits into from
Aug 31, 2020
Merged

Update CONTRIBUTING.md #2378

merged 6 commits into from
Aug 31, 2020

Conversation

muskanvk
Copy link
Contributor

@muskanvk muskanvk commented Aug 31, 2020 •
edited
Loading

  1. fixed dead link to the license in CONTRIBUTING.md file
  2. Added the MIT License to README.md file
  • Add an algorithm?
  • [Y ] Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [ Y] I have read CONTRIBUTING.md.
  • [Y ] This pull request is all my own work -- I have not plagiarized.
  • [Y ] I know that pull requests will not be merged if they fail the automated tests.
  • [Y ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [Y ] All new Python files are placed inside an existing directory.
  • [Y ] All filenames are in all lowercase characters with no spaces or dashes.
  • [ Y] All functions and variable names follow Python naming conventions.
  • [ Y] All function parameters and return values are annotated with Python type hints.
  • [ Y] All functions have doctests that pass the automated testing.
  • [Y ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ Y] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@muskanvk
Update CONTRIBUTING.md
f3935bf 
fixed dead link to the license
@muskanvk muskanvk mentioned this pull request Aug 31, 2020
Closed
cclauss
cclauss reviewed Aug 31, 2020
View reviewed changes
README.md Outdated
@@ -1,5 +1,6 @@
# The Algorithms - Python
[![Gitpod Ready-to-Code](https://img.shields.io/badge/Gitpod-Ready--to--Code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/TheAlgorithms/Python)
[![Gitpod Ready-to-Code](https://img.shields.io/badge/Gitpod-Ready--to--Code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/TheAlgorithms/Python)
![](https://img.shields.io/github/license/sourcerer-io/hall-of-fame.svg?colorB=ff0000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the license shield (MIT License) that I have added

@cclauss cclauss merged commit e92e433 into TheAlgorithms:master Aug 31, 2020
@TravisBuddy
Copy link

Hey @muskanvk,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 26414a50-ebc1-11ea-95c6-05b7905ca42d

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@muskanvk @cclauss @stokhos
Update CONTRIBUTING.md (TheAlgorithms#2378)
66d28e4 
* Update CONTRIBUTING.md

fixed dead link to the license

* Update README.md

Added License

* Update README.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muskanvk @TravisBuddy @cclauss