-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Finding Exponent Program #2238
Added Finding Exponent Program #2238
Conversation
Hey @Utsav1999, TravisCI finished with status TravisBuddy Request Identifier: 999fef60-cf6a-11ea-9502-ed86ad10d0d8 |
Hey @Utsav1999, TravisCI finished with status TravisBuddy Request Identifier: 5f521af0-cf6e-11ea-9502-ed86ad10d0d8 |
I do not understand this algorithm. We say that we are "finding the exponent" but we are emulating https://docs.python.org/3/library/functions.html#pow which returns base to the power exp. That is that exp is an input to the function, not an output of it. In my suggestions at #2236 (comment) I added more self-documenting variable names and doctests. Without these elements, the PR will not be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I can say it power calculation program instead of saying Finding exponent program. |
@cclauss
|
Hey @Utsav1999, TravisCI finished with status TravisBuddy Request Identifier: 65baf6b0-cfea-11ea-81e3-a59d363db46c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks for your submission
Hey @Utsav1999, TravisCI finished with status TravisBuddy Request Identifier: 43de8730-cfec-11ea-81e3-a59d363db46c |
@TravisBuddy hates when we merge too fast. There is nothing wrong here except that we merged the PR before Travis could finish. |
* Finding Exponent Program * Build Error Fix - 1 * Build Error Fix - 2 * Error Fix - 1 datatype * self-documenting naming convension added * Update and rename exponent_recursion.py to power_using_recursion.py * Fix typo * Fix typo Co-authored-by: Christian Clauss <cclauss@me.com>
Describe your change:
Python recursion program for finding exponent.
Checklist:
Fixes: #{$ISSUE_NO}
.