Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Finding Exponent Program #2238

Merged
merged 8 commits into from
Jul 27, 2020
Merged

Added Finding Exponent Program #2238

merged 8 commits into from
Jul 27, 2020

Conversation

Utsav1999
Copy link
Contributor

Describe your change:

Python recursion program for finding exponent.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Hey @Utsav1999,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 999fef60-cf6a-11ea-9502-ed86ad10d0d8

@TravisBuddy
Copy link

Hey @Utsav1999,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 5f521af0-cf6e-11ea-9502-ed86ad10d0d8

@cclauss
Copy link
Member

cclauss commented Jul 26, 2020

I do not understand this algorithm. We say that we are "finding the exponent" but we are emulating https://docs.python.org/3/library/functions.html#pow which returns base to the power exp. That is that exp is an input to the function, not an output of it. In my suggestions at #2236 (comment) I added more self-documenting variable names and doctests. Without these elements, the PR will not be merged.

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss cclauss added on hold require tests Tests [doctest/unittest/pytest] are required labels Jul 26, 2020
@Utsav1999
Copy link
Contributor Author

Then I can say it power calculation program instead of saying Finding exponent program.

@Utsav1999
Copy link
Contributor Author

@cclauss
Below are some inputs and outputs according to your test cases.
Enter the base: 10 Enter the exponent: 10 10 to the power of 10: 10000000000

Enter the base: -9 Enter the exponent: 10 -9 to the power of 10: 3486784401

Enter the base: 8 Enter the exponent: 6 8 to the power of 6: 262144

@TravisBuddy
Copy link

Hey @Utsav1999,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 65baf6b0-cfea-11ea-81e3-a59d363db46c

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for your submission

@cclauss cclauss merged commit dfb4ce4 into TheAlgorithms:master Jul 27, 2020
@TravisBuddy
Copy link

Hey @Utsav1999,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 43de8730-cfec-11ea-81e3-a59d363db46c

@cclauss
Copy link
Member

cclauss commented Jul 27, 2020

@TravisBuddy hates when we merge too fast. There is nothing wrong here except that we merged the PR before Travis could finish.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Finding Exponent Program

* Build Error Fix - 1

* Build Error Fix - 2

* Error Fix - 1 datatype

* self-documenting naming convension added

* Update and rename exponent_recursion.py to power_using_recursion.py

* Fix typo

* Fix typo

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold require tests Tests [doctest/unittest/pytest] are required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants