Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "Inverse of Matrix" Algorithm #2209

Merged
merged 7 commits into from
Jul 23, 2020
Merged

Added "Inverse of Matrix" Algorithm #2209

merged 7 commits into from
Jul 23, 2020

Conversation

RobotGuy999
Copy link
Contributor

@RobotGuy999 RobotGuy999 commented Jul 17, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Hey @RobotGuy999,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: c30f2d90-c842-11ea-ab6f-3547fdb4f9a3

cclauss
cclauss requested changes Jul 17, 2020
View reviewed changes
ruppysuppy
ruppysuppy suggested changes Jul 18, 2020
View reviewed changes
Copy link
Member

@ruppysuppy ruppysuppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the flake8 styling

@cclauss
Copy link
Member

cclauss commented Jul 18, 2020

Travis CI finds 6 flake8 issues: https://travis-ci.com/github/TheAlgorithms/Python/builds/176071407#L252

@TravisBuddy
Copy link

Travis tests have failed

Hey @RobotGuy999,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6fc84710-ca8c-11ea-84bb-258f0278865c

@TravisBuddy
Copy link

Travis tests have failed

Hey @RobotGuy999,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 4ec3d0f0-caa2-11ea-84bb-258f0278865c

cclauss
cclauss approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@cclauss cclauss merged commit a823a86 into TheAlgorithms:master Jul 23, 2020
@cclauss
Copy link
Member

cclauss commented Jul 23, 2020

swapped_matrix = [row[::-1] for row in matrix][::-1]

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@RobotGuy999 @cclauss @stokhos
Added "Inverse of Matrix" Algorithm (TheAlgorithms#2209)
6b77803 
* Added "Inverse of Matrix" Algorithm

* Small quotation marks change

* Update inverse_of_matrix.py

* Updated doctests

* Update inverse_of_matrix.py

* Add type hints

* swaped --> swapped

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruppysuppy ruppysuppy ruppysuppy requested changes

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RobotGuy999 @TravisBuddy @cclauss @ruppysuppy