Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add round_robin scheduling algorithm #2158

Merged
merged 15 commits into from
Jul 3, 2020
Merged

Add round_robin scheduling algorithm #2158

merged 15 commits into from
Jul 3, 2020
+65 −0

Conversation

pawanbuddy2000
Copy link
Contributor

@pawanbuddy2000 pawanbuddy2000 commented Jun 29, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Not Found
@TravisBuddy
Copy link

Hey @pawanbuddy2000,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 32bb5ac0-ba0a-11ea-a74d-ef5d1a577ce8

@TravisBuddy
Copy link

Hey @pawanbuddy2000,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 975b5220-ba17-11ea-a74d-ef5d1a577ce8

@cclauss
Copy link
Member

cclauss commented Jun 29, 2020

https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md No type hints, no doctests, please format code with psf/black, please use snake_case_for_function_and_variable_names, etc.
https://travis-ci.com/github/TheAlgorithms/Python/builds/173491468#L252

@cclauss cclauss added tests are failing Do not merge until tests pass require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Jun 29, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @pawanbuddy2000,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 995df5d0-bc0d-11ea-937a-75d40a178b7c

cclauss
cclauss requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On your local machine, try python3 -m doctest -v round_robin.py and make sure all doctests pass.

@pawanbuddy2000 @cclauss
Update scheduling/round_robin_scheduling_algorithm.py
2151f4a 
Co-authored-by: Christian Clauss <cclauss@me.com>
@TravisBuddy
Copy link

Travis tests have failed

Hey @pawanbuddy2000,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 15eb07b0-bcad-11ea-ab91-9125a069a76b

@pawanbuddy2000 @cclauss
Update scheduling/round_robin.py
0e156d6 
Co-authored-by: Christian Clauss <cclauss@me.com>
@TravisBuddy
Copy link

Travis tests have failed

Hey @pawanbuddy2000,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6b95cea0-bcaf-11ea-ab91-9125a069a76b

pawanbuddy2000 and others added 3 commits July 3, 2020 03:52
@pawanbuddy2000 @cclauss
Update scheduling/round_robin_scheduling.py
8df2f10 
Co-authored-by: Christian Clauss <cclauss@me.com>
@pawanbuddy2000 @cclauss
Update scheduling/round_robin_scheduling.py
5620bd9 
Co-authored-by: Christian Clauss <cclauss@me.com>
@pawanbuddy2000 @cclauss
Update scheduling/round_robin.py
2aa35dd 
Co-authored-by: Christian Clauss <cclauss@me.com>
@TravisBuddy
Copy link

Travis tests have failed

Hey @pawanbuddy2000,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: c22fecb0-bcb3-11ea-ab91-9125a069a76b

@cclauss cclauss changed the title Priority and round_robin cpu scheduling algorithms Add round_robin scheduling algorithm Jul 3, 2020
@TravisBuddy
Copy link

Hey @pawanbuddy2000,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d9694dc0-bd28-11ea-ab91-9125a069a76b

@TravisBuddy
Copy link

Hey @pawanbuddy2000,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 23873b90-bd2b-11ea-ab91-9125a069a76b

@pawanbuddy2000
Copy link
Contributor Author

Sir, my last code passes all the tests right....

@pawanbuddy2000
Copy link
Contributor Author

pawanbuddy2000 commented Jul 3, 2020 •
edited
Loading

Sir, Python type hints functions should be only be declared in List?

@cclauss cclauss removed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html tests are failing Do not merge until tests pass labels Jul 3, 2020
cclauss
cclauss approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this awesome contribution!!

@cclauss cclauss merged commit e274863 into TheAlgorithms:master Jul 3, 2020
@cclauss
Copy link
Member

cclauss commented Jul 3, 2020

Python type hints functions should be only be declared in List?

Each of these functions is taking in a list of ints which is written in Python type hints as List[int].

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@pawanbuddy2000 @pawanbuddy
@cclauss @stokhos
Add round_robin scheduling algorithm (TheAlgorithms#2158)
7cb96f1 
* round_robin and priority cpu scheduling algorithms

* Delete priority_cpu_scheduling.py

* Delete round_robin_algorithm.py

* [add] cpu_scheduling_algorithms

* [add] Round robin cpu scheduling algorithm

* Update scheduling/round_robin_scheduling_algorithm.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update scheduling/round_robin.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update scheduling/round_robin_scheduling.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update scheduling/round_robin_scheduling.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update scheduling/round_robin.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Round_Robin

* Update round_robin.py

* Update round_robin.py

* Update round_robin.py

* Update round_robin.py

Co-authored-by: pawanbuddy <46370996+pawanbuddy@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pawanbuddy2000 @TravisBuddy @cclauss @pawanbuddy