Skip to content

added data structure questions #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

added data structure questions #1845

wants to merge 1 commit into from

Conversation

Shrutikabansal
Copy link
Contributor

@Shrutikabansal Shrutikabansal commented Apr 9, 2020

Describe your change:

Added Algorithm related to DynamicPrograming and Backtracking

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.



Example Output
Ouptut 1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Power of A = 24 and Power of B = 48.
So, the answer is 0.
'''

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss
Copy link
Member

cclauss commented Apr 9, 2020

data_structures/Backtracking/sudoku.cpp does not belong in this repoo. It belongs in https://github.com/TheAlgorithms/C-Plus-Plus

@cclauss
Copy link
Member

cclauss commented Apr 9, 2020

@cclauss
Copy link
Member

cclauss commented Apr 9, 2020

This PR should only change one algorithm file. To ease review, please open separate PRs for separate algorithms.

@Shrutikabansal
Copy link
Contributor Author

"This PR should only change one algorithm file. To ease review, please open separate PRs for separate algorithms." I got this point but why checks are failing

@cclauss
Copy link
Member

cclauss commented Apr 9, 2020

Why checks are failing?

48    E101 indentation contains mixed spaces and tabs
8     E999 TabError: inconsistent use of tabs and spaces in indentation
8     F821 undefined name 'sys'
56    W191 indentation contains tabs
120

https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md

@Shrutikabansal
Copy link
Contributor Author

Okay I'll do again and then raise the pr
Thank you so much

@cclauss
Copy link
Member

cclauss commented Apr 10, 2020

There is a standalone Python file in the CPython distribution called reindent.py that can autofix those pesky tabs... https://github.com/python/cpython/blob/master/Tools/scripts/reindent.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants