Repository navigation
sorts: make power_sort generic over comparable items - #15542
Open
LearnCodeZaid wants to merge 1 commit into
Open
LearnCodeZaid wants to merge 1 commit into
LearnCodeZaid wants to merge 1 commit into
Conversation
Add Comparable protocol and PEP 695 TypeVar bound so power_sort, _find_run and _merge accept list[T] instead of bare list/Any. Add string and TypeError doctests; register in shared SORTS battery and non-comparable rejection test. Part of TheAlgorithms#15234
algorithms-keeper
Bot
added
awaiting reviews
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15234
Describe your change
Make power_sort, _find_run and _merge generic over a Comparable protocol (PEP 695 TypeVar bound) instead of bare list/Any. Add string-sorting and TypeError doctests. Register power_sort in the shared SORTS battery and the non-comparable rejection test.
Validation: pytest tests/test_sorts.py sorts/power_sort.py --doctest-modules = 447 passed. ruff check + format clean.
Checklist