Update treap.py #1358
Merged
Update treap.py #1358
+116
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check merge()
cclauss
requested changes
Oct 18, 2019
data_structures/binary_tree/treap.py
Outdated
| def split(root: Node, key: int) -> Tuple[Node, Node]: | ||
| """ | ||
| We split current tree into 2 trees with key: | ||
| We split current tree into 2 trees with key: |
There was a problem hiding this comment.
This extra indentation is not recommended by https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings
data_structures/binary_tree/treap.py
Outdated
| """ | ||
| root.r, r = split(root.r, key) | ||
| return (root, r) | ||
| if key < root.key: |
There was a problem hiding this comment.
This indentation after a return statement makes this unreachable code. If you are using TABS for indentation then please stop. If you are using four spaces for indentation then please explain why this change is useful.
There was a problem hiding this comment.
return is deleted...
data_structures/binary_tree/treap.py
Outdated
| pre_print(root.l) | ||
| print(root.key, end=" ") | ||
| pre_print(root.r) | ||
| def mid_print(root: Node): |
There was a problem hiding this comment.
Put two blank lines between functions or better yet, reformat with black.
random() is used. its difficult to write doctests l->left r->right key->value add __repr__ and __str__ in preorder
cclauss
approved these changes
Oct 18, 2019
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Update treap.py check merge() * Update treap.py random() is used. its difficult to write doctests l->left r->right key->value add __repr__ and __str__ in preorder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check merge()