Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12510 #12517

Merged
merged 8 commits into from
Jan 12, 2025
Merged

Fix #12510 #12517

merged 8 commits into from
Jan 12, 2025

Conversation

XenoBytesX
Copy link
Contributor

@XenoBytesX XenoBytesX commented Jan 12, 2025

Describe your change:

Fix #12510

  • Add an algorithm?
  • [✔] Fix a bug or typo in an existing algorithm?
  • [✔] Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • [✔] I have read CONTRIBUTING.md.
  • [✔] This pull request is all my own work -- I have not plagiarized.
  • [✔] I know that pull requests will not be merged if they fail the automated tests.
  • [✔] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [✔] All new Python files are placed inside an existing directory.
  • [✔] All filenames are in all lowercase characters with no spaces or dashes.
  • [✔] All functions and variable names follow Python naming conventions.
  • [✔] All function parameters and return values are annotated with Python type hints.
  • [✔] All functions have doctests that pass the automated testing.
  • [✔] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [✔] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jan 12, 2025
Copy link
Member

@MaximSmolskiy MaximSmolskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XenoBytesX Thanks for PR. I changed fix to minimum possible - bug was in case if we meet element that is less than pivot, then we consider rest of array (and we should not filter it in any way), but we filter it

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jan 12, 2025
@MaximSmolskiy MaximSmolskiy merged commit 4c92de5 into TheAlgorithms:master Jan 12, 2025
4 of 5 checks passed
@XenoBytesX XenoBytesX deleted the bug_fix branch January 13, 2025 02:44
@isidroas isidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dynamic_programming/longest_increasing_subsequence.py
2 participants