Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doctests to interpolation_search.py #11492

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Add doctests to interpolation_search.py #11492

merged 5 commits into from
Jul 25, 2024

Conversation

Ihor-Pryyma
Copy link
Contributor

Describe your change:

Contributes to #9943

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Abonimohan
Abonimohan suggested changes Jul 20, 2024
View reviewed changes
Copy link

@Abonimohan Abonimohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 11-12 please check it out

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jul 20, 2024
@Ihor-Pryyma Ihor-Pryyma requested a review from Abonimohan July 20, 2024 16:16
imSanko
imSanko suggested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value not in ("#", ""). Use a set if the elements are hashable.

@Ihor-Pryyma
Copy link
Contributor Author

value not in ("#", ""). Use a set if the elements are hashable.

but that file is not in my PR

cclauss
cclauss reviewed Jul 23, 2024
View reviewed changes
searches/interpolation_search.py Outdated
Comment on lines 21 to 22
>>> interpolation_search([1, 2, 3, 4, 5], 6)
>>> interpolation_search([], 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>>> interpolation_search([1, 2, 3, 4, 5], 6)
>>> interpolation_search([], 1)
>>> interpolation_search([1, 2, 3, 4, 5], 6) is None
True
>>> interpolation_search([], 1) is None
True

Please repeat below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@cclauss
Copy link
Member

cclauss commented Jul 23, 2024

web_programming/emails_from_url.py was fixed in a separate pull request.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Jul 25, 2024
@Ihor-Pryyma Ihor-Pryyma requested review from cclauss and imSanko July 25, 2024 14:31
imSanko
imSanko reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to be @cclauss will let know better to move forward with this.

cclauss
cclauss approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jul 25, 2024
@cclauss cclauss merged commit 1468003 into TheAlgorithms:master Jul 25, 2024
3 checks passed
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Ihor-Pryyma @sedatguzelsemme
Add doctests to interpolation_search.py (TheAlgorithms#11492)
9181777 
* Add doctests to interpolation_search.py

* update docs

* update tests

* update tests 2

* clean code
cclauss pushed a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@Ihor-Pryyma @cclauss
Add doctests to interpolation_search.py (TheAlgorithms#11492)
67e21d5 
* Add doctests to interpolation_search.py

* update docs

* update tests

* update tests 2

* clean code
cclauss pushed a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@Ihor-Pryyma @cclauss
Add doctests to interpolation_search.py (TheAlgorithms#11492)
82130af 
* Add doctests to interpolation_search.py

* update docs

* update tests

* update tests 2

* clean code
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imSanko imSanko imSanko requested changes

@cclauss cclauss cclauss approved these changes

@Abonimohan Abonimohan Awaiting requested review from Abonimohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ihor-Pryyma @cclauss @imSanko @Abonimohan