-
-
Notifications
You must be signed in to change notification settings - Fork 45.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Gaussian elimination pivoting #11393
base: master
Are you sure you want to change the base?
Fix Gaussian elimination pivoting #11393
Conversation
@tianyizheng02 please review |
|
||
# Upper triangular matrix | ||
if ab[column_num, column_num] == 0.0: | ||
raise ValueError("Matrix is not correct") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have the error say "Matrix is singular" instead? "Not correct" is very vague. (This will need to be updated in the function docstring as well.)
/ ab[column_num - 1, column_num - 1] | ||
* ab[column_num - 1, :] | ||
) | ||
assert num_of_rows == num_of_columns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of an assert
, let's just have the function raise a ValueError
instead.
pass | ||
|
||
# Upper triangular matrix | ||
if ab[column_num, column_num] == 0.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a tolerance for this comparison? That is, is there a risk that floating-point errors can cause this check to incorrectly fail?
Describe your change:
Fix Gaussian elimination pivoting and warning:
on build
Run tests
stageChecklist: