-
-
Notifications
You must be signed in to change notification settings - Fork 45.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding negative binary base conversion algorithms #11213
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess you can't be add multiple Algos in a single PR.
Hi! Thank you for your feedback. Did you mean that two different files cannot be addressed in one PR? If so, then, the reason I put these two files in one PR is for time efficiency (for reviewers to not check both files in different PR's), and convenience, due to the fact that they are directly related. What are your thoughts about that? Would you recommend I separate them, considering the above information, or keep them like they are? |
…meg-1/Python into negative_binary_base_alogrithms
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check out Contribution.md while like the maintainers can help you know better in that, but having fixing or adding more than also you can do 2 PR at a time rather adding it into a single one!
Describe your change:
Adding two negative binary base conversion algorithms:
more about negative binary base: link
Checklist: