Skip to content

Added tests for validate_sudoku_board.py #11089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Added tests for validate_sudoku_board.py #11089

wants to merge 8 commits into from

Conversation

AksharGoyal
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword:

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 30, 2023
@cclauss
Copy link
Member

cclauss commented Oct 30, 2023

Closing. This pull request modifies eight different files.

@cclauss cclauss closed this Oct 30, 2023
@AksharGoyal
Copy link
Contributor Author

Hi @cclauss , I am not sure how writing tests for Sudoku affected other files. Can I get some more information on how it happened so that if I open another PR it doesn't affect them?

@cclauss
Copy link
Member

cclauss commented Oct 30, 2023

The trick is to always create pull requests on a branch other than master.

  1. Go to https://github.com/AksharGoyal/Python and click the Sync fork button so your master is up-to-date
  2. Go to https://github.com/AksharGoyal/Python/branches and click the New branch button at the upper-right and give the branch a name that makes it clear what the intended change is.

If 1. is not done before 2. the previous edits can creep in.

@AksharGoyal
Copy link
Contributor Author

I did create a branch this time for adding tests for sudoku but looks like the PR from last time affected this one. I will re-fork and create a branch so this time nothing is affected. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants