Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to graphs/dijkstra_2.py #11015

Closed
wants to merge 4 commits into from
Closed

Add tests to graphs/dijkstra_2.py #11015

wants to merge 4 commits into from

Conversation

Johannes2755
Copy link

Describe your change:

Created docstring and test cases for the min_dist helper function in dijkstra_2, as it is a non-void function. Contributes to #9943 .

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 26, 2023
cclauss
cclauss reviewed Oct 27, 2023
View reviewed changes
graphs/dijkstra_2.py
Comment on lines +36 to +39
print(u)
print(mdist)
print(vset)
print(v)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these lines. CONTRIBUTING.md says that algorithmic functions should not print().

@cclauss cclauss self-assigned this Oct 29, 2023
@cclauss cclauss added the awaiting changes A maintainer has requested changes to this PR label Oct 29, 2023
@cclauss cclauss changed the title Testcases2 Add tests to graphs/dijkstra_2.py Oct 29, 2023
@cclauss
Copy link
Member

cclauss commented Sep 30, 2024

Closing tests_are_failing PRs to prepare for Hacktoberfest 2024

@cclauss cclauss closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

Assignees

@cclauss cclauss

Labels
awaiting changes A maintainer has requested changes to this PR awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Johannes2755 @cclauss