-
-
Notifications
You must be signed in to change notification settings - Fork 47k
Create Sudoku_Solver.py #10619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Sudoku_Solver.py #10619
Conversation
Each of the digits 1-9 must occur exactly once in each row. Each of the digits 1-9 must occur exactly once in each column. Each of the digits 1-9 must occur exactly once in each of the 9 3x3 sub-boxes of the grid. The '.' character indicates empty cells.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
@@ -0,0 +1,44 @@ | |||
class Solution: | |||
def solveSudoku(self, board: List[List[str]]) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/sudoku_solver.py
, please provide doctest for the function solveSudoku
Variable and function names should follow the snake_case
naming convention. Please update the following name accordingly: solveSudoku
n = 9 | ||
|
||
|
||
def isValid(row, col, ch): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/sudoku_solver.py
, please provide doctest for the function isValid
Please provide return type hint for the function: isValid
. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case
naming convention. Please update the following name accordingly: isValid
Please provide type hint for the parameter: row
Please provide type hint for the parameter: col
Please provide type hint for the parameter: ch
|
||
return True | ||
|
||
def solve(row, col): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/sudoku_solver.py
, please provide doctest for the function solve
Please provide return type hint for the function: solve
. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: row
Please provide type hint for the parameter: col
for more information, see https://pre-commit.ci
sudoku_solver |
Each of the digits 1-9 must occur exactly once in each row. Each of the digits 1-9 must occur exactly once in each column. Each of the digits 1-9 must occur exactly once in each of the 9 3x3 sub-boxes of the grid. The '.' character indicates empty cells.
Describe your change:
Checklist: