Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mobius Function #1058

Merged
merged 11 commits into from
Jul 21, 2019
Merged

Added Mobius Function #1058

merged 11 commits into from
Jul 21, 2019

Conversation

QuantumNovice
Copy link
Contributor

No description provided.

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reuse and formatting...

maths/is_square_free.py Outdated Show resolved Hide resolved
maths/is_square_free.py Outdated Show resolved Hide resolved
maths/is_square_free.py Outdated Show resolved Hide resolved
maths/is_square_free.py Outdated Show resolved Hide resolved
maths/is_square_free.py Outdated Show resolved Hide resolved
maths/mobius_function.py Outdated Show resolved Hide resolved
maths/mobius_function.py Outdated Show resolved Hide resolved
maths/mobius_function.py Outdated Show resolved Hide resolved
maths/mobius_function.py Outdated Show resolved Hide resolved
maths/mobius_function.py Outdated Show resolved Hide resolved
mobius_function.py Outdated Show resolved Hide resolved
@cclauss
Copy link
Member

cclauss commented Jul 20, 2019

Add an EMPTY file named maths/__init__.py which will make maths a package.

@QuantumNovice
Copy link
Contributor Author

QuantumNovice commented Jul 21, 2019

Travis builds failed because it ran on the old defective code (2nd Last commit). How do I trigger a new build?

@cclauss
Copy link
Member

cclauss commented Jul 21, 2019

I restarted at https://travis-ci.org/TheAlgorithms/Python/builds/561450460?utm_source=github_status&utm_medium=notification

If you want to rebuild, you need to make and commit an insignificant change like add or modify a comment. Just mark that commit with "Force a build" so it is clear to your readers.

Output: https://travis-ci.org/TheAlgorithms/Python/builds/561450460#L550

mobius_function.py Outdated Show resolved Hide resolved
@cclauss
Copy link
Member

cclauss commented Jul 21, 2019

I think we are really close here. I was able to get the tests to pass locally just by doing touch maths/__init__.py__ and git add __init__.py__. This creates an empty maths/__init__.py__ file which makes maths into a Python package which allows the imports to work. The one downside of this approach is that when you run locally you need to run from in the directory above maths. So you maths/mobius_function.py to run that script and code mobius_function.py to edit that script, etc.

maths/mobius_function.py Outdated Show resolved Hide resolved
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME!! Thanks for the perseverance.

@cclauss cclauss merged commit c964d74 into TheAlgorithms:master Jul 21, 2019
@cclauss
Copy link
Member

cclauss commented Jul 21, 2019

Merged.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Add files via upload

* Update mobius_function.py

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update mobius_function.py

* Delete mobius_function.py

* Add files via upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants