-
-
Notifications
You must be signed in to change notification settings - Fork 61
chore: configure gitpod #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frankly, I'm not much of a fan of Gitpod; I don't really see the benefits.
All this does for a newcomer is set up a crippled Ubuntu image with Lua, Luarocks, Luacheck and Busted installed in a "cloud development environment". To actually commit their changes, users would further need to grant wide-reaching permissions to Gitpod. I don't think this is how newcomers should approach this, depending on Gitpod just to save them 5 minutes of setting up the dependencies.
Ultimately, programmers - and this includes newcomers to this repo - need to be able to set up a dev environment. Given the few and simple "dependencies" of this repo, I see no need to involve Docker - over a 3rd-party service, no less - yet; again, I don't think we should lead newcomers to use Gitpod.
(And even if Gitpod were to lower the barrier to entry, that won't necessarily be a good thing; I doubt that someone who would have been unable to set up a dev environment is able to make a substantial contribution.)
That said, to "show the newcomers how to create their own development environment", we should probably add a "getting started" section to the Readme - adding some links to the Lua / Luarocks / Luacheck / Busted installation / getting started pages, perhaps even a few ready-to-go commands and instructions for the most popular operating systems for convenience.
Newcomers will have to deal with dev env setup either way; neither Luacheck nor Busted invoke themselves, and for Luacheck I highly recommend editor support; it doesn't even seem possible to install a Luacheck extension on Gitpod out of the box:
Screenshot from local VSC:
Screenshot from Gitpod:
(perhaps this is fixable?)
If Gitpod support were accepted, this PR would also be missing a mention of Gitpod in the Readme.
@appgurueu I think that the cost of maintaining gitpod setup is minimal. The benefits are that (gitpod users) can contribute from a browser. If I would not find it useful, I would not create this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not strongly opposed to this; it is true that the maintenance cost is limited, though I think users would probably be best advised to avoid Gitpod (but at the end of the day, they are still free to choose).
Thanks for the PR! |
This PR allows to use this repository in gitpod.
In the created environment, it is possible to successfully run the commands
and
luacheck .
Besides the fact that several repositories in
TheAlgorithms
are ready to use in gitpod, I think it is a good idea to have it, since it shows the newcomers how to create their own development environment.